Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/download/download_query.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index a09046225c6c495300f1659b6601fcee43ea3bd8..7e409747144740e9586354f4717a1036f4a75c9e 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -1239,7 +1239,7 @@ void DevToolsWindow::OnLoadCompleted() {
SessionTabHelper* session_tab_helper =
SessionTabHelper::FromWebContents(inspected_web_contents);
if (session_tab_helper) {
- base::FundamentalValue tabId(session_tab_helper->session_id().id());
+ base::Value tabId(session_tab_helper->session_id().id());
bindings_->CallClientFunction("DevToolsAPI.setInspectedTabId",
&tabId, NULL, NULL);
}
@@ -1325,8 +1325,8 @@ void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {
action.params();
CHECK(params);
base::StringValue url_value(params->url);
- base::FundamentalValue line_value(static_cast<int>(params->line_number));
- base::FundamentalValue column_value(
+ base::Value line_value(static_cast<int>(params->line_number));
+ base::Value column_value(
static_cast<int>(params->column_number));
bindings_->CallClientFunction("DevToolsAPI.revealSourceLine",
&url_value, &line_value, &column_value);
@@ -1384,7 +1384,7 @@ bool DevToolsWindow::ReloadInspectedWebContents(bool bypass_cache) {
WebContents* wc = GetInspectedWebContents();
if (!wc || wc->GetCrashedStatus() != base::TERMINATION_STATUS_STILL_RUNNING)
return false;
- base::FundamentalValue bypass_cache_value(bypass_cache);
+ base::Value bypass_cache_value(bypass_cache);
bindings_->CallClientFunction("DevToolsAPI.reloadInspectedPage",
&bypass_cache_value, nullptr, nullptr);
return true;
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/download/download_query.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698