chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('k') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc b/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

index 726ed4968321366cd54d1f6b2af8afc078d2b7fd..2434fcad3448bc22f3fe7200a2e5faddd9b403d8 100644

--- a/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

@@ -59,7 +59,7 @@ TEST_F(SupervisedUserProviderTest, GeolocationTest) {

_, _, CONTENT_SETTINGS_TYPE_GEOLOCATION, ""));

service_.SetLocalSetting(

supervised_users::kGeolocationDisabled,

- std::unique_ptr<base::Value>(new base::FundamentalValue(true)));

+ std::unique_ptr<base::Value>(new base::Value(true)));

rule_iterator = provider_->GetRuleIterator(CONTENT_SETTINGS_TYPE_GEOLOCATION,

std::string(), false);

@@ -77,7 +77,7 @@ TEST_F(SupervisedUserProviderTest, GeolocationTest) {

_, _, CONTENT_SETTINGS_TYPE_GEOLOCATION, ""));

service_.SetLocalSetting(

supervised_users::kGeolocationDisabled,

- std::unique_ptr<base::Value>(new base::FundamentalValue(false)));

+ std::unique_ptr<base::Value>(new base::Value(false)));

rule_iterator = provider_->GetRuleIterator(CONTENT_SETTINGS_TYPE_GEOLOCATION,

std::string(), false);

@@ -103,7 +103,7 @@ TEST_F(SupervisedUserProviderTest, CameraMicTest) {

OnContentSettingChanged(_, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, ""));

service_.SetLocalSetting(

supervised_users::kCameraMicDisabled,

- std::unique_ptr<base::Value>(new base::FundamentalValue(true)));

+ std::unique_ptr<base::Value>(new base::Value(true)));

rule_iterator = provider_->GetRuleIterator(

CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), false);

@@ -136,7 +136,7 @@ TEST_F(SupervisedUserProviderTest, CameraMicTest) {

OnContentSettingChanged(_, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, ""));

service_.SetLocalSetting(

supervised_users::kCameraMicDisabled,

- std::unique_ptr<base::Value>(new base::FundamentalValue(false)));

+ std::unique_ptr<base::Value>(new base::Value(false)));

rule_iterator = provider_->GetRuleIterator(

CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), false);