chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc ('k') | chrome/browser/chromeos/extensions/info_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

index 99c1c8cc37fa2df5d5b124e753a3ae0c33d391a6..2b7e6e18444e8665c2274f37adab9f66c4fdaef0 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

@@ -239,8 +239,7 @@ FileManagerPrivateInternalSetDefaultTaskFunction::Run() {

// TODO(gspencer): Fix file manager so that it never tries to set default in

// cases where extensionless local files are part of the selection.

if (suffixes.empty() && mime_types.empty()) {

- return RespondNow(

- OneArgument(base::MakeUnique<base::FundamentalValue>(true)));

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(true)));

}

file_manager::file_tasks::UpdateDefaultTask(