Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: components/prefs/in_memory_pref_store_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/in_memory_pref_store.h" 5 #include "components/prefs/in_memory_pref_store.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "components/prefs/pref_store_observer_mock.h" 9 #include "components/prefs/pref_store_observer_mock.h"
10 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 10 matching lines...) Expand all
21 scoped_refptr<InMemoryPrefStore> store_; 21 scoped_refptr<InMemoryPrefStore> store_;
22 PrefStoreObserverMock observer_; 22 PrefStoreObserverMock observer_;
23 }; 23 };
24 24
25 TEST_F(InMemoryPrefStoreTest, SetGetValue) { 25 TEST_F(InMemoryPrefStoreTest, SetGetValue) {
26 const base::Value* value = NULL; 26 const base::Value* value = NULL;
27 base::Value* mutable_value = NULL; 27 base::Value* mutable_value = NULL;
28 EXPECT_FALSE(store_->GetValue(kTestPref, &value)); 28 EXPECT_FALSE(store_->GetValue(kTestPref, &value));
29 EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value)); 29 EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value));
30 30
31 store_->SetValue(kTestPref, base::MakeUnique<base::FundamentalValue>(42), 31 store_->SetValue(kTestPref, base::MakeUnique<base::Value>(42),
32 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 32 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
33 EXPECT_TRUE(store_->GetValue(kTestPref, &value)); 33 EXPECT_TRUE(store_->GetValue(kTestPref, &value));
34 EXPECT_TRUE(base::FundamentalValue(42).Equals(value)); 34 EXPECT_TRUE(base::Value(42).Equals(value));
35 EXPECT_TRUE(store_->GetMutableValue(kTestPref, &mutable_value)); 35 EXPECT_TRUE(store_->GetMutableValue(kTestPref, &mutable_value));
36 EXPECT_TRUE(base::FundamentalValue(42).Equals(mutable_value)); 36 EXPECT_TRUE(base::Value(42).Equals(mutable_value));
37 37
38 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 38 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
39 EXPECT_FALSE(store_->GetValue(kTestPref, &value)); 39 EXPECT_FALSE(store_->GetValue(kTestPref, &value));
40 EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value)); 40 EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value));
41 } 41 }
42 42
43 TEST_F(InMemoryPrefStoreTest, GetSetObserver) { 43 TEST_F(InMemoryPrefStoreTest, GetSetObserver) {
44 // Starts with no observers. 44 // Starts with no observers.
45 EXPECT_FALSE(store_->HasObservers()); 45 EXPECT_FALSE(store_->HasObservers());
46 46
47 // Add one. 47 // Add one.
48 store_->AddObserver(&observer_); 48 store_->AddObserver(&observer_);
49 EXPECT_TRUE(store_->HasObservers()); 49 EXPECT_TRUE(store_->HasObservers());
50 50
51 // Remove only observer. 51 // Remove only observer.
52 store_->RemoveObserver(&observer_); 52 store_->RemoveObserver(&observer_);
53 EXPECT_FALSE(store_->HasObservers()); 53 EXPECT_FALSE(store_->HasObservers());
54 } 54 }
55 55
56 TEST_F(InMemoryPrefStoreTest, CallObserver) { 56 TEST_F(InMemoryPrefStoreTest, CallObserver) {
57 // With observer included. 57 // With observer included.
58 store_->AddObserver(&observer_); 58 store_->AddObserver(&observer_);
59 59
60 // Triggers on SetValue. 60 // Triggers on SetValue.
61 store_->SetValue(kTestPref, base::MakeUnique<base::FundamentalValue>(42), 61 store_->SetValue(kTestPref, base::MakeUnique<base::Value>(42),
62 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 62 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
63 observer_.VerifyAndResetChangedKey(kTestPref); 63 observer_.VerifyAndResetChangedKey(kTestPref);
64 64
65 // And RemoveValue. 65 // And RemoveValue.
66 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 66 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
67 observer_.VerifyAndResetChangedKey(kTestPref); 67 observer_.VerifyAndResetChangedKey(kTestPref);
68 68
69 // But not SetValueSilently. 69 // But not SetValueSilently.
70 store_->SetValueSilently(kTestPref, 70 store_->SetValueSilently(kTestPref,
71 base::MakeUnique<base::FundamentalValue>(42), 71 base::MakeUnique<base::Value>(42),
72 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 72 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
73 EXPECT_EQ(0u, observer_.changed_keys.size()); 73 EXPECT_EQ(0u, observer_.changed_keys.size());
74 74
75 // On multiple RemoveValues only the first one triggers observer. 75 // On multiple RemoveValues only the first one triggers observer.
76 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 76 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
77 observer_.VerifyAndResetChangedKey(kTestPref); 77 observer_.VerifyAndResetChangedKey(kTestPref);
78 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 78 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
79 EXPECT_EQ(0u, observer_.changed_keys.size()); 79 EXPECT_EQ(0u, observer_.changed_keys.size());
80 80
81 // Doesn't make call on removed observers. 81 // Doesn't make call on removed observers.
82 store_->RemoveObserver(&observer_); 82 store_->RemoveObserver(&observer_);
83 store_->SetValue(kTestPref, base::MakeUnique<base::FundamentalValue>(42), 83 store_->SetValue(kTestPref, base::MakeUnique<base::Value>(42),
84 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 84 WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
85 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); 85 store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
86 EXPECT_EQ(0u, observer_.changed_keys.size()); 86 EXPECT_EQ(0u, observer_.changed_keys.size());
87 } 87 }
88 88
89 TEST_F(InMemoryPrefStoreTest, Initialization) { 89 TEST_F(InMemoryPrefStoreTest, Initialization) {
90 EXPECT_TRUE(store_->IsInitializationComplete()); 90 EXPECT_TRUE(store_->IsInitializationComplete());
91 } 91 }
92 92
93 TEST_F(InMemoryPrefStoreTest, ReadOnly) { 93 TEST_F(InMemoryPrefStoreTest, ReadOnly) {
94 EXPECT_FALSE(store_->ReadOnly()); 94 EXPECT_FALSE(store_->ReadOnly());
95 } 95 }
96 96
97 TEST_F(InMemoryPrefStoreTest, GetReadError) { 97 TEST_F(InMemoryPrefStoreTest, GetReadError) {
98 EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->GetReadError()); 98 EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->GetReadError());
99 } 99 }
100 100
101 TEST_F(InMemoryPrefStoreTest, ReadPrefs) { 101 TEST_F(InMemoryPrefStoreTest, ReadPrefs) {
102 EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->ReadPrefs()); 102 EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->ReadPrefs());
103 } 103 }
104 104
105 } // namespace 105 } // namespace
OLDNEW
« no previous file with comments | « components/prefs/command_line_pref_store.cc ('k') | components/prefs/json_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698