Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: components/browser_sync/profile_sync_service_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/browser_sync/profile_sync_service.h" 5 #include "components/browser_sync/profile_sync_service.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 TEST_F(ProfileSyncServiceTest, InitialState) { 391 TEST_F(ProfileSyncServiceTest, InitialState) {
392 CreateService(ProfileSyncService::AUTO_START); 392 CreateService(ProfileSyncService::AUTO_START);
393 InitializeForNthSync(); 393 InitializeForNthSync();
394 const std::string& url = service()->sync_service_url().spec(); 394 const std::string& url = service()->sync_service_url().spec();
395 EXPECT_TRUE(url == syncer::internal::kSyncServerUrl || 395 EXPECT_TRUE(url == syncer::internal::kSyncServerUrl ||
396 url == syncer::internal::kSyncDevServerUrl); 396 url == syncer::internal::kSyncDevServerUrl);
397 } 397 }
398 398
399 // Verify a successful initialization. 399 // Verify a successful initialization.
400 TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) { 400 TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) {
401 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, 401 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(false));
402 new base::FundamentalValue(false));
403 IssueTestTokens(); 402 IssueTestTokens();
404 CreateService(ProfileSyncService::AUTO_START); 403 CreateService(ProfileSyncService::AUTO_START);
405 ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback()); 404 ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
406 ExpectSyncBackendHostCreation(1); 405 ExpectSyncBackendHostCreation(1);
407 InitializeForNthSync(); 406 InitializeForNthSync();
408 EXPECT_FALSE(service()->IsManaged()); 407 EXPECT_FALSE(service()->IsManaged());
409 EXPECT_TRUE(service()->IsSyncActive()); 408 EXPECT_TRUE(service()->IsSyncActive());
410 } 409 }
411 410
412 // Verify that an initialization where first setup is not complete does not 411 // Verify that an initialization where first setup is not complete does not
413 // start up the backend. 412 // start up the backend.
414 TEST_F(ProfileSyncServiceTest, NeedsConfirmation) { 413 TEST_F(ProfileSyncServiceTest, NeedsConfirmation) {
415 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, 414 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(false));
416 new base::FundamentalValue(false));
417 IssueTestTokens(); 415 IssueTestTokens();
418 CreateService(ProfileSyncService::MANUAL_START); 416 CreateService(ProfileSyncService::MANUAL_START);
419 syncer::SyncPrefs sync_prefs(prefs()); 417 syncer::SyncPrefs sync_prefs(prefs());
420 base::Time now = base::Time::Now(); 418 base::Time now = base::Time::Now();
421 sync_prefs.SetLastSyncedTime(now); 419 sync_prefs.SetLastSyncedTime(now);
422 sync_prefs.SetKeepEverythingSynced(true); 420 sync_prefs.SetKeepEverythingSynced(true);
423 service()->Initialize(); 421 service()->Initialize();
424 EXPECT_FALSE(service()->IsSyncActive()); 422 EXPECT_FALSE(service()->IsSyncActive());
425 423
426 // The last sync time shouldn't be cleared. 424 // The last sync time shouldn't be cleared.
(...skipping 14 matching lines...) Expand all
441 auto sync_blocker = service()->GetSetupInProgressHandle(); 439 auto sync_blocker = service()->GetSetupInProgressHandle();
442 EXPECT_TRUE(observer.setup_in_progress()); 440 EXPECT_TRUE(observer.setup_in_progress());
443 sync_blocker.reset(); 441 sync_blocker.reset();
444 EXPECT_FALSE(observer.setup_in_progress()); 442 EXPECT_FALSE(observer.setup_in_progress());
445 443
446 service()->RemoveObserver(&observer); 444 service()->RemoveObserver(&observer);
447 } 445 }
448 446
449 // Verify that disable by enterprise policy works. 447 // Verify that disable by enterprise policy works.
450 TEST_F(ProfileSyncServiceTest, DisabledByPolicyBeforeInit) { 448 TEST_F(ProfileSyncServiceTest, DisabledByPolicyBeforeInit) {
451 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, 449 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(true));
452 new base::FundamentalValue(true));
453 IssueTestTokens(); 450 IssueTestTokens();
454 CreateService(ProfileSyncService::AUTO_START); 451 CreateService(ProfileSyncService::AUTO_START);
455 InitializeForNthSync(); 452 InitializeForNthSync();
456 EXPECT_TRUE(service()->IsManaged()); 453 EXPECT_TRUE(service()->IsManaged());
457 EXPECT_FALSE(service()->IsSyncActive()); 454 EXPECT_FALSE(service()->IsSyncActive());
458 } 455 }
459 456
460 // Verify that disable by enterprise policy works even after the backend has 457 // Verify that disable by enterprise policy works even after the backend has
461 // been initialized. 458 // been initialized.
462 TEST_F(ProfileSyncServiceTest, DisabledByPolicyAfterInit) { 459 TEST_F(ProfileSyncServiceTest, DisabledByPolicyAfterInit) {
463 IssueTestTokens(); 460 IssueTestTokens();
464 CreateService(ProfileSyncService::AUTO_START); 461 CreateService(ProfileSyncService::AUTO_START);
465 ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback()); 462 ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
466 ExpectSyncBackendHostCreation(1); 463 ExpectSyncBackendHostCreation(1);
467 InitializeForNthSync(); 464 InitializeForNthSync();
468 465
469 EXPECT_FALSE(service()->IsManaged()); 466 EXPECT_FALSE(service()->IsManaged());
470 EXPECT_TRUE(service()->IsSyncActive()); 467 EXPECT_TRUE(service()->IsSyncActive());
471 468
472 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, 469 prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(true));
473 new base::FundamentalValue(true));
474 470
475 EXPECT_TRUE(service()->IsManaged()); 471 EXPECT_TRUE(service()->IsManaged());
476 EXPECT_FALSE(service()->IsSyncActive()); 472 EXPECT_FALSE(service()->IsSyncActive());
477 } 473 }
478 474
479 // Exercies the ProfileSyncService's code paths related to getting shut down 475 // Exercies the ProfileSyncService's code paths related to getting shut down
480 // before the backend initialize call returns. 476 // before the backend initialize call returns.
481 TEST_F(ProfileSyncServiceTest, AbortedByShutdown) { 477 TEST_F(ProfileSyncServiceTest, AbortedByShutdown) {
482 CreateService(ProfileSyncService::AUTO_START); 478 CreateService(ProfileSyncService::AUTO_START);
483 PrepareDelayedInitSyncBackendHost(); 479 PrepareDelayedInitSyncBackendHost();
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 // Progress the controller to RUNNING first, which is how the service 965 // Progress the controller to RUNNING first, which is how the service
970 // determines whether a type is enabled. 966 // determines whether a type is enabled.
971 controller->StartAssociating(base::Bind(&DoNothing)); 967 controller->StartAssociating(base::Bind(&DoNothing));
972 controller->FinishStart(DataTypeController::OK_FIRST_RUN); 968 controller->FinishStart(DataTypeController::OK_FIRST_RUN);
973 service()->RegisterDataTypeController(std::move(controller)); 969 service()->RegisterDataTypeController(std::move(controller));
974 EXPECT_NE(nullptr, service()->GetOpenTabsUIDelegate()); 970 EXPECT_NE(nullptr, service()->GetOpenTabsUIDelegate());
975 } 971 }
976 972
977 } // namespace 973 } // namespace
978 } // namespace browser_sync 974 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698