Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/test/chromedriver/element_commands.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/element_commands.h" 5 #include "chrome/test/chromedriver/element_commands.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <list> 10 #include <list>
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 } 520 }
521 521
522 Status ExecuteElementEquals(Session* session, 522 Status ExecuteElementEquals(Session* session,
523 WebView* web_view, 523 WebView* web_view,
524 const std::string& element_id, 524 const std::string& element_id,
525 const base::DictionaryValue& params, 525 const base::DictionaryValue& params,
526 std::unique_ptr<base::Value>* value) { 526 std::unique_ptr<base::Value>* value) {
527 std::string other_element_id; 527 std::string other_element_id;
528 if (!params.GetString("other", &other_element_id)) 528 if (!params.GetString("other", &other_element_id))
529 return Status(kUnknownError, "'other' must be a string"); 529 return Status(kUnknownError, "'other' must be a string");
530 value->reset(new base::FundamentalValue(element_id == other_element_id)); 530 value->reset(new base::Value(element_id == other_element_id));
531 return Status(kOk); 531 return Status(kOk);
532 } 532 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/server/http_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698