Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/policy/profile_policy_connector_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/profile_policy_connector.h" 5 #include "chrome/browser/policy/profile_policy_connector.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 // No policy is set initially. 93 // No policy is set initially.
94 EXPECT_FALSE( 94 EXPECT_FALSE(
95 connector.IsPolicyFromCloudPolicy(autofill::prefs::kAutofillEnabled)); 95 connector.IsPolicyFromCloudPolicy(autofill::prefs::kAutofillEnabled));
96 PolicyNamespace chrome_ns(POLICY_DOMAIN_CHROME, std::string()); 96 PolicyNamespace chrome_ns(POLICY_DOMAIN_CHROME, std::string());
97 EXPECT_FALSE(connector.policy_service()->GetPolicies(chrome_ns).GetValue( 97 EXPECT_FALSE(connector.policy_service()->GetPolicies(chrome_ns).GetValue(
98 key::kAutoFillEnabled)); 98 key::kAutoFillEnabled));
99 99
100 // Set the policy at the cloud provider. 100 // Set the policy at the cloud provider.
101 cloud_policy_store_.policy_map_.Set( 101 cloud_policy_store_.policy_map_.Set(
102 key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 102 key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
103 POLICY_SOURCE_CLOUD, base::MakeUnique<base::FundamentalValue>(false), 103 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(false),
104 nullptr); 104 nullptr);
105 cloud_policy_store_.NotifyStoreLoaded(); 105 cloud_policy_store_.NotifyStoreLoaded();
106 base::RunLoop().RunUntilIdle(); 106 base::RunLoop().RunUntilIdle();
107 EXPECT_TRUE(connector.IsPolicyFromCloudPolicy(key::kAutoFillEnabled)); 107 EXPECT_TRUE(connector.IsPolicyFromCloudPolicy(key::kAutoFillEnabled));
108 const base::Value* value = 108 const base::Value* value =
109 connector.policy_service()->GetPolicies(chrome_ns).GetValue( 109 connector.policy_service()->GetPolicies(chrome_ns).GetValue(
110 key::kAutoFillEnabled); 110 key::kAutoFillEnabled);
111 ASSERT_TRUE(value); 111 ASSERT_TRUE(value);
112 EXPECT_TRUE(base::FundamentalValue(false).Equals(value)); 112 EXPECT_TRUE(base::Value(false).Equals(value));
113 113
114 // Now test with a higher-priority provider also setting the policy. 114 // Now test with a higher-priority provider also setting the policy.
115 PolicyMap map; 115 PolicyMap map;
116 map.Set(key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 116 map.Set(key::kAutoFillEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
117 POLICY_SOURCE_CLOUD, base::MakeUnique<base::FundamentalValue>(true), 117 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(true),
118 nullptr); 118 nullptr);
119 mock_provider_.UpdateChromePolicy(map); 119 mock_provider_.UpdateChromePolicy(map);
120 EXPECT_FALSE(connector.IsPolicyFromCloudPolicy(key::kAutoFillEnabled)); 120 EXPECT_FALSE(connector.IsPolicyFromCloudPolicy(key::kAutoFillEnabled));
121 value = connector.policy_service()->GetPolicies(chrome_ns).GetValue( 121 value = connector.policy_service()->GetPolicies(chrome_ns).GetValue(
122 key::kAutoFillEnabled); 122 key::kAutoFillEnabled);
123 ASSERT_TRUE(value); 123 ASSERT_TRUE(value);
124 EXPECT_TRUE(base::FundamentalValue(true).Equals(value)); 124 EXPECT_TRUE(base::Value(true).Equals(value));
125 125
126 // Cleanup. 126 // Cleanup.
127 connector.Shutdown(); 127 connector.Shutdown();
128 } 128 }
129 129
130 } // namespace policy 130 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/policy/policy_startup_browsertest.cc ('k') | chrome/browser/prefs/chrome_command_line_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698