Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Side by Side Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h " 5 #include "chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h "
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 TEST_F(ScreenMagnifierPolicyHandlerTest, Default) { 58 TEST_F(ScreenMagnifierPolicyHandlerTest, Default) {
59 handler_.ApplyPolicySettings(policy_, &prefs_); 59 handler_.ApplyPolicySettings(policy_, &prefs_);
60 EXPECT_FALSE( 60 EXPECT_FALSE(
61 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, NULL)); 61 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, NULL));
62 EXPECT_FALSE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, NULL)); 62 EXPECT_FALSE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, NULL));
63 } 63 }
64 64
65 TEST_F(ScreenMagnifierPolicyHandlerTest, Disabled) { 65 TEST_F(ScreenMagnifierPolicyHandlerTest, Disabled) {
66 policy_.Set(key::kScreenMagnifierType, POLICY_LEVEL_MANDATORY, 66 policy_.Set(key::kScreenMagnifierType, POLICY_LEVEL_MANDATORY,
67 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 67 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
68 base::MakeUnique<base::FundamentalValue>(0), nullptr); 68 base::MakeUnique<base::Value>(0), nullptr);
69 handler_.ApplyPolicySettings(policy_, &prefs_); 69 handler_.ApplyPolicySettings(policy_, &prefs_);
70 70
71 const base::Value* enabled = NULL; 71 const base::Value* enabled = NULL;
72 EXPECT_TRUE( 72 EXPECT_TRUE(
73 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, &enabled)); 73 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, &enabled));
74 ASSERT_TRUE(enabled); 74 ASSERT_TRUE(enabled);
75 EXPECT_TRUE(base::FundamentalValue(false).Equals(enabled)); 75 EXPECT_TRUE(base::Value(false).Equals(enabled));
76 76
77 const base::Value* type = NULL; 77 const base::Value* type = NULL;
78 EXPECT_TRUE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, &type)); 78 EXPECT_TRUE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, &type));
79 ASSERT_TRUE(type); 79 ASSERT_TRUE(type);
80 EXPECT_TRUE(base::FundamentalValue(0).Equals(type)); 80 EXPECT_TRUE(base::Value(0).Equals(type));
81 } 81 }
82 82
83 TEST_F(ScreenMagnifierPolicyHandlerTest, Enabled) { 83 TEST_F(ScreenMagnifierPolicyHandlerTest, Enabled) {
84 policy_.Set(key::kScreenMagnifierType, POLICY_LEVEL_MANDATORY, 84 policy_.Set(key::kScreenMagnifierType, POLICY_LEVEL_MANDATORY,
85 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 85 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
86 base::MakeUnique<base::FundamentalValue>(1), nullptr); 86 base::MakeUnique<base::Value>(1), nullptr);
87 handler_.ApplyPolicySettings(policy_, &prefs_); 87 handler_.ApplyPolicySettings(policy_, &prefs_);
88 88
89 const base::Value* enabled = NULL; 89 const base::Value* enabled = NULL;
90 EXPECT_TRUE( 90 EXPECT_TRUE(
91 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, &enabled)); 91 prefs_.GetValue(prefs::kAccessibilityScreenMagnifierEnabled, &enabled));
92 ASSERT_TRUE(enabled); 92 ASSERT_TRUE(enabled);
93 EXPECT_TRUE(base::FundamentalValue(true).Equals(enabled)); 93 EXPECT_TRUE(base::Value(true).Equals(enabled));
94 94
95 const base::Value* type = NULL; 95 const base::Value* type = NULL;
96 EXPECT_TRUE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, &type)); 96 EXPECT_TRUE(prefs_.GetValue(prefs::kAccessibilityScreenMagnifierType, &type));
97 ASSERT_TRUE(type); 97 ASSERT_TRUE(type);
98 EXPECT_TRUE(base::FundamentalValue(1).Equals(type)); 98 EXPECT_TRUE(base::Value(1).Equals(type));
99 } 99 }
100 100
101 TEST(ExternalDataPolicyHandlerTest, Empty) { 101 TEST(ExternalDataPolicyHandlerTest, Empty) {
102 PolicyErrorMap errors; 102 PolicyErrorMap errors;
103 EXPECT_TRUE(ExternalDataPolicyHandler(key::kUserAvatarImage) 103 EXPECT_TRUE(ExternalDataPolicyHandler(key::kUserAvatarImage)
104 .CheckPolicySettings(PolicyMap(), &errors)); 104 .CheckPolicySettings(PolicyMap(), &errors));
105 EXPECT_TRUE(errors.GetErrors(key::kUserAvatarImage).empty()); 105 EXPECT_TRUE(errors.GetErrors(key::kUserAvatarImage).empty());
106 } 106 }
107 107
108 TEST(ExternalDataPolicyHandlerTest, WrongType) { 108 TEST(ExternalDataPolicyHandlerTest, WrongType) {
109 PolicyMap policy_map; 109 PolicyMap policy_map;
110 policy_map.Set(key::kUserAvatarImage, POLICY_LEVEL_MANDATORY, 110 policy_map.Set(key::kUserAvatarImage, POLICY_LEVEL_MANDATORY,
111 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 111 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
112 base::MakeUnique<base::FundamentalValue>(false), nullptr); 112 base::MakeUnique<base::Value>(false), nullptr);
113 PolicyErrorMap errors; 113 PolicyErrorMap errors;
114 EXPECT_FALSE(ExternalDataPolicyHandler(key::kUserAvatarImage) 114 EXPECT_FALSE(ExternalDataPolicyHandler(key::kUserAvatarImage)
115 .CheckPolicySettings(policy_map, &errors)); 115 .CheckPolicySettings(policy_map, &errors));
116 EXPECT_FALSE(errors.GetErrors(key::kUserAvatarImage).empty()); 116 EXPECT_FALSE(errors.GetErrors(key::kUserAvatarImage).empty());
117 } 117 }
118 118
119 TEST(ExternalDataPolicyHandlerTest, MissingURL) { 119 TEST(ExternalDataPolicyHandlerTest, MissingURL) {
120 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue); 120 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
121 dict->SetString("hash", "1234567890123456789012345678901234567890"); 121 dict->SetString("hash", "1234567890123456789012345678901234567890");
122 PolicyMap policy_map; 122 PolicyMap policy_map;
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 NetworkConfigurationPolicyHandler::CreateForUserPolicy()); 242 NetworkConfigurationPolicyHandler::CreateForUserPolicy());
243 PolicyErrorMap errors; 243 PolicyErrorMap errors;
244 EXPECT_TRUE(handler->CheckPolicySettings(policy_map, &errors)); 244 EXPECT_TRUE(handler->CheckPolicySettings(policy_map, &errors));
245 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 245 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
246 } 246 }
247 247
248 TEST(NetworkConfigurationPolicyHandlerTest, WrongType) { 248 TEST(NetworkConfigurationPolicyHandlerTest, WrongType) {
249 PolicyMap policy_map; 249 PolicyMap policy_map;
250 policy_map.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY, 250 policy_map.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
251 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 251 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
252 base::MakeUnique<base::FundamentalValue>(false), nullptr); 252 base::MakeUnique<base::Value>(false), nullptr);
253 std::unique_ptr<NetworkConfigurationPolicyHandler> handler( 253 std::unique_ptr<NetworkConfigurationPolicyHandler> handler(
254 NetworkConfigurationPolicyHandler::CreateForUserPolicy()); 254 NetworkConfigurationPolicyHandler::CreateForUserPolicy());
255 PolicyErrorMap errors; 255 PolicyErrorMap errors;
256 EXPECT_FALSE(handler->CheckPolicySettings(policy_map, &errors)); 256 EXPECT_FALSE(handler->CheckPolicySettings(policy_map, &errors));
257 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 257 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
258 } 258 }
259 259
260 TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) { 260 TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) {
261 const std::string kTestONC("I'm not proper JSON!"); 261 const std::string kTestONC("I'm not proper JSON!");
262 PolicyMap policy_map; 262 PolicyMap policy_map;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_); 348 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_);
349 PolicyErrorMap errors; 349 PolicyErrorMap errors;
350 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors)); 350 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
351 EXPECT_TRUE(errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty()); 351 EXPECT_TRUE(errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty());
352 } 352 }
353 353
354 TEST_F(LoginScreenPowerManagementPolicyHandlerTest, WrongType) { 354 TEST_F(LoginScreenPowerManagementPolicyHandlerTest, WrongType) {
355 PolicyMap policy_map; 355 PolicyMap policy_map;
356 policy_map.Set(key::kDeviceLoginScreenPowerManagement, POLICY_LEVEL_MANDATORY, 356 policy_map.Set(key::kDeviceLoginScreenPowerManagement, POLICY_LEVEL_MANDATORY,
357 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 357 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
358 base::MakeUnique<base::FundamentalValue>(false), nullptr); 358 base::MakeUnique<base::Value>(false), nullptr);
359 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_); 359 LoginScreenPowerManagementPolicyHandler handler(chrome_schema_);
360 PolicyErrorMap errors; 360 PolicyErrorMap errors;
361 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors)); 361 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors));
362 EXPECT_FALSE( 362 EXPECT_FALSE(
363 errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty()); 363 errors.GetErrors(key::kDeviceLoginScreenPowerManagement).empty());
364 } 364 }
365 365
366 } // namespace policy 366 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698