Add chrome namespace to chrome/common/resource_usage_reporter.mojom

Add chrome namespace to chrome/common/resource_usage_reporter.mojom

BUG=

Committed: https://crrev.com/48a860313f49c529cd567db05edf2ada46f95304
Cr-Commit-Position: refs/heads/master@{#434410}

[nigeltao1, 2016-11-03 01:14:21]

The CQ bit was checked by nigeltao@chromium.org to run a CQ dry run

[nigeltao1, 2016-11-03 01:14:33]

nigeltao@chromium.org changed reviewers:
+ rockot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:23:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-11-03 04:46:52]

lgtm

[nigeltao1, 2016-11-03 23:11:16]

nigeltao@chromium.org changed reviewers:
+ sky@chromium.org

[nigeltao1, 2016-11-03 23:11:16]

sky, can you review for OWNERS?

[sky, 2016-11-03 23:41:02]

LGTM

[nigeltao1, 2016-11-04 05:40:19]

The CQ bit was checked by nigeltao@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:40:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:49:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nigeltao1, 2016-11-05 23:42:22]

nigeltao@chromium.org changed reviewers:
+ tsepez@chromium.org

[nigeltao1, 2016-11-05 23:42:23]

tsepez, can you review for ipc/SECURITY_OWNERS?

[Tom Sepez, 2016-11-07 17:53:18]

RS LGTM on namespacing.

[nigeltao1, 2016-11-10 01:23:19]

The CQ bit was checked by nigeltao@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:23:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 01:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:33:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nigeltao1, 2016-11-10 05:07:42]

The CQ bit was checked by nigeltao@chromium.org

[nigeltao1, 2016-11-10 05:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2476493002/#ps20001
(title: "Add chrome namespace to chrome/common/resource_usage_reporter.mojom")

[commit-bot: I haz the power, 2016-11-10 05:07:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 05:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 05:14:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nigeltao1, 2016-11-10 05:15:52]

On 2016/11/07 17:53:18, Tom Sepez wrote:
> RS LGTM on namespacing.

Sorry for the Chromium noob question, but the commit queue is still complaining.
Is the leading "RS" confusing the bot??

https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
says:

***************
chrome/common/OWNERS is missing the following lines:

per-file *_type_converter*.*=set noparent
per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS

for changed files:
  chrome/common/resource_usage_reporter.mojom
  chrome/common/resource_usage_reporter_type_converters.cc
  chrome/common/resource_usage_reporter_type_converters.h
***************

[Ken Rockot(use gerrit already), 2016-11-10 17:22:54]

On 2016/11/10 at 05:15:52, nigeltao wrote:
> On 2016/11/07 17:53:18, Tom Sepez wrote:
> > RS LGTM on namespacing.
> 
> Sorry for the Chromium noob question, but the commit queue is still
complaining. Is the leading "RS" confusing the bot??
> 
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
says:
> 
> ***************
> chrome/common/OWNERS is missing the following lines:
> 
> per-file *_type_converter*.*=set noparent
> per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS
> 
> for changed files:
>   chrome/common/resource_usage_reporter.mojom
>   chrome/common/resource_usage_reporter_type_converters.cc
>   chrome/common/resource_usage_reporter_type_converters.h
> ***************

No, the RS is fine. (Also RS LGTM)

The problem is exactly what the error message says: We require OWNERS files next
to every mojom file, and they must contain at least the "per-file" lines
specified in the message. This is to ensure that all mojom changes trigger a
presubmit check for security review.

[Ken Rockot(use gerrit already), 2016-11-10 17:23:35]

On 2016/11/10 at 17:22:54, Ken Rockot wrote:
> On 2016/11/10 at 05:15:52, nigeltao wrote:
> > On 2016/11/07 17:53:18, Tom Sepez wrote:
> > > RS LGTM on namespacing.
> > 
> > Sorry for the Chromium noob question, but the commit queue is still
complaining. Is the leading "RS" confusing the bot??
> > 
> >
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
says:
> > 
> > ***************
> > chrome/common/OWNERS is missing the following lines:
> > 
> > per-file *_type_converter*.*=set noparent
> > per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS
> > 
> > for changed files:
> >   chrome/common/resource_usage_reporter.mojom
> >   chrome/common/resource_usage_reporter_type_converters.cc
> >   chrome/common/resource_usage_reporter_type_converters.h
> > ***************
> 
> No, the RS is fine. (Also RS LGTM)
> 
> The problem is exactly what the error message says: We require OWNERS files
next to every mojom file, and they must contain at least the "per-file" lines
specified in the message. This is to ensure that all mojom changes trigger a
presubmit check for security review.

Also note that this policy was adopted after many mojoms landed in the tree, so
changing existing mojoms can trigger the check. You should add the OWNERS file
in this CL.

[nigeltao1, 2016-11-17 03:50:26]

On 2016/11/10 17:23:35, Ken Rockot wrote:
> Also note that this policy was adopted after many mojoms landed in the tree,
so
> changing existing mojoms can trigger the check. You should add the OWNERS file
> in this CL.

Done. The ```
per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS
```
lines are duplicated in that OWNERS file, but I'll fix that in a follow-up CL.

[nigeltao1, 2016-11-17 03:51:32]

The CQ bit was checked by nigeltao@chromium.org

[nigeltao1, 2016-11-17 03:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2476493002/#ps40001
(title: "Add chrome namespace to chrome/common/resource_usage_reporter.mojom")

[commit-bot: I haz the power, 2016-11-17 03:52:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:08:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nigeltao1, 2016-11-18 03:56:41]

The CQ bit was checked by nigeltao@chromium.org

[nigeltao1, 2016-11-18 03:56:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2476493002/#ps60001
(title: "Add chrome namespace to chrome/common/resource_usage_reporter.mojom")

[commit-bot: I haz the power, 2016-11-18 03:57:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 06:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 06:08:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nigeltao1, 2016-11-19 23:13:35]

The CQ bit was checked by nigeltao@chromium.org

[nigeltao1, 2016-11-19 23:13:36]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2476493002/#ps80001
(title: "Add chrome namespace to chrome/common/resource_usage_reporter.mojom")

[commit-bot: I haz the power, 2016-11-19 23:13:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 03:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 03:14:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nigeltao1, 2016-11-23 23:57:54]

The CQ bit was checked by nigeltao@chromium.org

[nigeltao1, 2016-11-23 23:57:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2476493002/#ps100001
(title: "Add chrome namespace to chrome/common/resource_usage_reporter.mojom")

[commit-bot: I haz the power, 2016-11-23 23:58:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:03:48]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[nigeltao1, 2016-11-24 23:49:11]

The CQ bit was checked by nigeltao@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:49:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 00:04:20]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480031351782370,
"parent_rev": "3a12c487616470aa619818b455f5757935c028b8", "commit_rev":
"4d4d62e9d90056cbc2a580481d381daa8d563b9a"}

[commit-bot: I haz the power, 2016-11-25 00:04:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-25 00:09:03]

Description was changed from

==========
Add chrome namespace to chrome/common/resource_usage_reporter.mojom

BUG=
==========

to

==========
Add chrome namespace to chrome/common/resource_usage_reporter.mojom

BUG=

Committed: https://crrev.com/48a860313f49c529cd567db05edf2ada46f95304
Cr-Commit-Position: refs/heads/master@{#434410}
==========

[commit-bot: I haz the power, 2016-11-25 00:09:05]

Patchset 6 (id:??) landed as
https://crrev.com/48a860313f49c529cd567db05edf2ada46f95304
Cr-Commit-Position: refs/heads/master@{#434410}