Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2476473002: Ozone Linux: Fix linker errors in headless_unittests (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
4 years, 1 month ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone Linux: Fix linker errors in headless_unittests BUG=295089 R=skyostil@chromium.org Committed: https://crrev.com/b8468a79ce654fd5594c4ab2b5b40e7b45a71e3d Cr-Commit-Position: refs/heads/master@{#429548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M headless/public/util/error_reporter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom (Use chromium acct)
skyostil@ PTAL
4 years, 1 month ago (2016-11-02 23:45:28 UTC) #1
Sami
Whoops, thanks a lot for the fix! lgtm.
4 years, 1 month ago (2016-11-03 11:12:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476473002/1
4 years, 1 month ago (2016-11-03 11:13:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 12:50:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 12:54:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8468a79ce654fd5594c4ab2b5b40e7b45a71e3d
Cr-Commit-Position: refs/heads/master@{#429548}

Powered by Google App Engine
This is Rietveld 408576698