Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Issue 2476423003: [crankshaft] FIx for in deopt at the end of the loop. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] FIx for in deopt at the end of the loop. We really should deopt before the for-in index increment. BUG=chromium:662904 Committed: https://crrev.com/5d898441308f8cc47f22970917364b32189c220e Cr-Commit-Position: refs/heads/master@{#40828}

Patch Set 1 #

Patch Set 2 : Also check warm-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-662904.js View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-08 12:04:51 UTC) #4
Benedikt Meurer
Awesome, LGTM.
4 years, 1 month ago (2016-11-08 12:06:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476423003/20001
4 years, 1 month ago (2016-11-08 12:08:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 12:33:39 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d898441308f8cc47f22970917364b32189c220e
Cr-Commit-Position: refs/heads/master@{#40828}

Powered by Google App Engine
This is Rietveld 408576698