Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h

Issue 2476393003: V8ObjectBuilder::addString support Nullable. (Closed)
Patch Set: Add V8ObjectBuilderTest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h b/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
index f3bc32a773e9df7d42d8da88065da677d5fa1aef..b5219bcd411ac3abfcec153cd3e4245dfae53a2c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
@@ -29,7 +29,9 @@ class CORE_EXPORT V8ObjectBuilder final {
V8ObjectBuilder& addNull(const String& name);
V8ObjectBuilder& addBoolean(const String& name, bool value);
V8ObjectBuilder& addNumber(const String& name, double value);
- V8ObjectBuilder& addString(const String& name, const String& value);
+ V8ObjectBuilder& addString(const String& name,
Yuki 2016/11/09 07:25:50 It's okay to follow the old style, but const S
+ const String& value,
+ bool isNullable = false);
Yuki 2016/11/09 07:25:50 In general, we should avoid a boolean flag, I thin
template <typename T>
V8ObjectBuilder& add(const String& name, const T& value) {
« no previous file with comments | « third_party/WebKit/Source/bindings/bindings.gni ('k') | third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698