Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h

Issue 2476393003: V8ObjectBuilder::addString support Nullable. (Closed)
Patch Set: Fix nit. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h b/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
index f3bc32a773e9df7d42d8da88065da677d5fa1aef..9a04d80d9f6e1508f40ab902cda5670930aea463 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
@@ -24,15 +24,17 @@ class CORE_EXPORT V8ObjectBuilder final {
ScriptState* getScriptState() const { return m_scriptState.get(); }
- V8ObjectBuilder& add(const String& name, const V8ObjectBuilder&);
+ V8ObjectBuilder& add(const StringView& name, const V8ObjectBuilder&);
- V8ObjectBuilder& addNull(const String& name);
- V8ObjectBuilder& addBoolean(const String& name, bool value);
- V8ObjectBuilder& addNumber(const String& name, double value);
- V8ObjectBuilder& addString(const String& name, const String& value);
+ V8ObjectBuilder& addNull(const StringView& name);
+ V8ObjectBuilder& addBoolean(const StringView& name, bool value);
+ V8ObjectBuilder& addNumber(const StringView& name, double value);
+ V8ObjectBuilder& addString(const StringView& name, const StringView& value);
+ V8ObjectBuilder& addStringOrNull(const StringView& name,
+ const StringView& value);
template <typename T>
- V8ObjectBuilder& add(const String& name, const T& value) {
+ V8ObjectBuilder& add(const StringView& name, const T& value) {
addInternal(name, v8::Local<v8::Value>(
toV8(value, m_scriptState->context()->Global(),
m_scriptState->isolate())));
@@ -43,7 +45,7 @@ class CORE_EXPORT V8ObjectBuilder final {
v8::Local<v8::Object> v8Value() const { return m_object; }
private:
- void addInternal(const String& name, v8::Local<v8::Value>);
+ void addInternal(const StringView& name, v8::Local<v8::Value>);
RefPtr<ScriptState> m_scriptState;
v8::Local<v8::Object> m_object;
« no previous file with comments | « third_party/WebKit/Source/bindings/bindings.gni ('k') | third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698