Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2476373004: [ios] Removed User Action reporting from CRWSessionController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed User Action reporting from CRWSessionController. User Action will be added to Tab code to match other platforms behavior: Back and Forward actions are reported only when user taps Back or Forward buttons; nothing is reported for HTML5 JS navigations and user navigations initiated via long press and picking item from the dropdown. BUG=663072 Committed: https://crrev.com/9f212096c8a1c0da4eea20c2069763fedd1a26b1 Cr-Commit-Position: refs/heads/master@{#430948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M ios/web/navigation/crw_session_controller.mm View 3 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-09 02:52:13 UTC) #2
marq (ping after 24h)
lgtm
4 years, 1 month ago (2016-11-09 08:01:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476373004/1
4 years, 1 month ago (2016-11-09 16:25:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 16:30:56 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 16:34:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f212096c8a1c0da4eea20c2069763fedd1a26b1
Cr-Commit-Position: refs/heads/master@{#430948}

Powered by Google App Engine
This is Rietveld 408576698