Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2476363002: [ios] Made -[CRWWebController finishHistoryNavigationFromEntry:] private (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Made -[CRWWebController finishHistoryNavigationFromEntry:] private finishHistoryNavigationFromEntry is not called anywhere externally. BUG=None Committed: https://crrev.com/2c80237016d17ef20c30771249648663d15fa1c0 Cr-Commit-Position: refs/heads/master@{#430350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-07 19:19:28 UTC) #6
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-07 19:45:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476363002/1
4 years, 1 month ago (2016-11-07 19:45:51 UTC) #9
Eugene But (OOO till 7-30)
Thank you for quick review!
4 years, 1 month ago (2016-11-07 19:50:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:52:00 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 20:05:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c80237016d17ef20c30771249648663d15fa1c0
Cr-Commit-Position: refs/heads/master@{#430350}

Powered by Google App Engine
This is Rietveld 408576698