MD Settings: ignore 0% updates on help/about page

chrome/test/data/webui/settings/about_page_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_about_page', function() {
   /**
    * @constructor
    * @implements {settings.AboutPageBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
@@ skipping 47 matching lines @@
     },
 
     /** @override */
     pageReady: function() {
       this.methodCalled('pageReady');
     },
 
     /** @override */
     refreshUpdateStatus: function() {
       cr.webUIListenerCallback('update-status-changed', {
-        progress: 0,
+        progress: 1,
         status: this.updateStatus_,
       });
       this.methodCalled('refreshUpdateStatus');
     },
 
     /** @override */
     openFeedbackDialog: function() {
       this.methodCalled('openFeedbackDialog');
     },
 
@@ skipping 52 matching lines @@
 
     /** @override */
     TestAboutPageBrowserProxy.prototype.setChannel = function(
         channel, isPowerwashAllowed) {
       this.methodCalled('setChannel', [channel, isPowerwashAllowed]);
     };
   }
 
 
   function registerAboutPageTests() {
-    /** @param {!UpdateStatus} status */
-    function fireStatusChanged(status) {
+    /**
+     * @param {!UpdateStatus} status
+     * @param {number=} opt_progress
+     */
+    function fireStatusChanged(status, opt_progress) {
       cr.webUIListenerCallback('update-status-changed', {
-        progress: 0,
+        progress: opt_progress === undefined ? 1 : opt_progress,
         status: status,
       });
     }
 
     suite('AboutPageTest', function() {
       var page = null;
 
       /** @type {?settings.TestAboutPageBrowserProxy} */
       var aboutBrowserProxy = null;
 
@@ skipping 40 matching lines @@
         assertTrue(!!icon);
         var statusMessageEl = page.$.updateStatusMessage;
         var previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.CHECKING);
         assertEquals(SPINNER_ICON, icon.src);
         assertEquals(null, icon.getAttribute('icon'));
         assertNotEquals(previousMessageText, statusMessageEl.textContent);
         previousMessageText = statusMessageEl.textContent;
 
-        fireStatusChanged(UpdateStatus.UPDATING);
+        fireStatusChanged(UpdateStatus.UPDATING, 0);
         assertEquals(SPINNER_ICON, icon.src);
         assertEquals(null, icon.getAttribute('icon'));
+        assertFalse(statusMessageEl.textContent.includes('%'));
         assertNotEquals(previousMessageText, statusMessageEl.textContent);
         previousMessageText = statusMessageEl.textContent;
 
+        fireStatusChanged(UpdateStatus.UPDATING, 1);
+        assertNotEquals(previousMessageText, statusMessageEl.textContent);
+        assertTrue(statusMessageEl.textContent.includes('%'));
+        previousMessageText = statusMessageEl.textContent;
+
         fireStatusChanged(UpdateStatus.NEARLY_UPDATED);
         assertEquals(null, icon.src);
         assertEquals('settings:check-circle', icon.icon);
         assertNotEquals(previousMessageText, statusMessageEl.textContent);
         previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.DISABLED_BY_ADMIN);
         assertEquals(null, icon.src);
         assertEquals('cr:domain', icon.icon);
         assertEquals(0, statusMessageEl.textContent.trim().length);
@@ skipping 484 matching lines @@
     registerTests: function() {
       if (cr.isChromeOS) {
         registerDetailedBuildInfoTests();
         registerChannelSwitcherDialogTests();
       }
       registerAboutPageTests();
     },
     registerOfficialBuildTests: registerOfficialBuildTests,
   };
 });