MD Settings: ignore 0% updates on help/about page

chrome/browser/resources/settings/about_page/about_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-about-page' contains version and OS related
  * information.
  */
 Polymer({
   is: 'settings-about-page',
@@ skipping 149 matching lines @@
       case UpdateStatus.UPDATED:
         return this.i18n('aboutUpgradeUpToDate');
       case UpdateStatus.UPDATING:
         assert(typeof this.currentUpdateStatusEvent_.progress == 'number');
         var progressPercent = this.currentUpdateStatusEvent_.progress + '%';
 
 <if expr="chromeos">
         if (this.currentChannel_ != this.targetChannel_) {
           return this.i18n('aboutUpgradeUpdatingChannelSwitch',
               this.i18n(settings.browserChannelToI18nId(this.targetChannel_)),
               progressPercent);

[Dan Beam, 2016/11/09 21:21:13]

i don't really care much about making a non-percent version of this because it's
cros-only

         }
 </if>
-        return this.i18n('aboutUpgradeUpdating', progressPercent);
+        if (this.currentUpdateStatusEvent_.progress > 0) {
+          // NOTE(dbeam): some platforms (i.e. Mac) always send 0% while
+          // updating (they don't support incremental upgrade progress). Though
+          // it's certainly quite possible to validly end up here with 0% on
+          // platforms that support incremental progress, nobody really likes
+          // seeing that they're 0% done with something.
+          return this.i18n('aboutUpgradeUpdatingPercent', progressPercent);
+        }
+        return this.i18n('aboutUpgradeUpdating');
       default:
         var message = this.currentUpdateStatusEvent_.message;
         return message ?
             parseHtmlSubset('<b>' + message + '</b>').firstChild.innerHTML :
             '';
     }
   },
 
   /**
    * @return {?string}
@@ skipping 109 matching lines @@
     });
   },
 
 <if expr="_google_chrome">
   /** @private */
   onReportIssueTap_: function() {
     this.aboutBrowserProxy_.openFeedbackDialog();
   },
 </if>
 });