ash/common/devtools/ash_devtools_dom_agent.h - Issue 2476353002: Fix bug where removed (but not deleted) windows are not reflected in the tree properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/devtools/ash_devtools_dom_agent.h

Issue 2476353002: Fix bug where removed (but not deleted) windows are not reflected in the tree properly (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/devtools/ash_devtools_dom_agent.h

diff --git a/ash/common/devtools/ash_devtools_dom_agent.h b/ash/common/devtools/ash_devtools_dom_agent.h

index 760671f742105bb36dad4908993ab72fae3a4a7d..97cae3050eb1eb042de35b0c9133e75b25403feb 100644

--- a/ash/common/devtools/ash_devtools_dom_agent.h

+++ b/ash/common/devtools/ash_devtools_dom_agent.h

@@ -28,7 +28,8 @@ class ASH_EXPORT AshDevToolsDOMAgent

std::unique_ptr<ui::devtools::protocol::DOM::Node>* out_root) override;

// WindowObserver

- void OnWindowDestroying(WmWindow* window) override;

+ void OnWindowTreeChanging(WmWindow* window,

+ const TreeChangeParams& params) override;

void OnWindowTreeChanged(WmWindow* window,

const TreeChangeParams& params) override;

void OnWindowStackingChanged(WmWindow* window) override;