don't rely on `identical` for comparing empty linked lists

don't rely on `identical` for comparing empty linked lists

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b2751a80ec894bbe1dc3049121b1747bcaefc16

[Harry Terkelsen, 2016-11-07 23:05:19]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-11-07 23:15:42]

lgtm

https://codereview.chromium.org/2476333003/diff/1/pkg/compiler/lib/src/ordere...
File pkg/compiler/lib/src/ordered_typeset.dart (right):

https://codereview.chromium.org/2476333003/diff/1/pkg/compiler/lib/src/ordere...
pkg/compiler/lib/src/ordered_typeset.dart:96: while (pointer.isNotEmpty &&
!identical(pointer, end)) {
I guess with the isNotEmpty, you would have been fine keeping the end as
constLink<DartType>(), right?

[Harry Terkelsen, 2016-11-07 23:31:30]

https://codereview.chromium.org/2476333003/diff/1/pkg/compiler/lib/src/ordere...
File pkg/compiler/lib/src/ordered_typeset.dart (right):

https://codereview.chromium.org/2476333003/diff/1/pkg/compiler/lib/src/ordere...
pkg/compiler/lib/src/ordered_typeset.dart:96: while (pointer.isNotEmpty &&
!identical(pointer, end)) {
On 2016/11/07 23:15:42, Siggi Cherem (dart-lang) wrote:
> I guess with the isNotEmpty, you would have been fine keeping the end as
> constLink<DartType>(), right?

oops, yes. I am adding it back and adding a TODO to get rid of the 'isNotEmpty'
check when constants are canonicalized properly

[Harry Terkelsen, 2016-11-07 23:48:49]

Description was changed from

==========
don't rely on `identical` for comparing empty linked lists

BUG=
==========

to

==========
don't rely on `identical` for comparing empty linked lists

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b2751a80ec894bbe1dc3049121b1747bcaefc16
==========

[Harry Terkelsen, 2016-11-07 23:48:49]

Committed patchset #2 (id:20001) manually as
4b2751a80ec894bbe1dc3049121b1747bcaefc16 (presubmit successful).