Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2476323003: [heap] Ceanup: Remove weak cell scavenging code (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Ceanup: Remove weak cell scavenging code WeakCells are never allocated in new space. BUG=chromium:651354 Committed: https://crrev.com/d50931f92f8471ac260f1b205c805888b99d9a10 Cr-Commit-Position: refs/heads/master@{#40841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
4 years, 1 month ago (2016-11-08 13:53:10 UTC) #1
ulan
lgtm
4 years, 1 month ago (2016-11-08 15:12:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476323003/1
4 years, 1 month ago (2016-11-08 15:14:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 15:15:56 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d50931f92f8471ac260f1b205c805888b99d9a10
Cr-Commit-Position: refs/heads/master@{#40841}

Powered by Google App Engine
This is Rietveld 408576698