Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2476303004: Make SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHostAndroid (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SurfaceFactory lifetime match frame_sink_id_ registration in DelegatedFrameHostAndroid This will allow further simplification/refactoring. BUG=657959 Committed: https://crrev.com/d6da33fd77e168bce08dfe17685e63785d4fb38f Cr-Commit-Position: refs/heads/master@{#430666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ui/android/delegated_frame_host_android.cc View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
piman
4 years, 1 month ago (2016-11-07 22:18:02 UTC) #4
boliu
lgtm
4 years, 1 month ago (2016-11-07 22:27:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476303004/1
4 years, 1 month ago (2016-11-07 22:33:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/298879)
4 years, 1 month ago (2016-11-07 22:40:08 UTC) #10
piman
+dtrainor for OWNERs
4 years, 1 month ago (2016-11-07 22:45:18 UTC) #12
David Trainor- moved to gerrit
lgtm!
4 years, 1 month ago (2016-11-08 16:22:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476303004/1
4 years, 1 month ago (2016-11-08 18:29:34 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:36:01 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:08:31 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6da33fd77e168bce08dfe17685e63785d4fb38f
Cr-Commit-Position: refs/heads/master@{#430666}

Powered by Google App Engine
This is Rietveld 408576698