Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2476293003: Move named constant to CharacterNames.h (Closed)

Created:
4 years, 1 month ago by xing.xu
Modified:
4 years, 1 month ago
Reviewers:
tkent, skobes
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Mikhail, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move named constant to CharacterNames.h This is a followup for https://codereview.chromium.org/2469983007/. Committed: https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1 Cr-Commit-Position: refs/heads/master@{#430752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CharacterNames.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
xing.xu
PTAL, thanks
4 years, 1 month ago (2016-11-08 11:01:49 UTC) #7
skobes
lgtm
4 years, 1 month ago (2016-11-08 17:23:33 UTC) #8
tkent
lgtm
4 years, 1 month ago (2016-11-08 23:06:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476293003/1
4 years, 1 month ago (2016-11-08 23:07:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 23:19:37 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:38:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1
Cr-Commit-Position: refs/heads/master@{#430752}

Powered by Google App Engine
This is Rietveld 408576698