Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2476273002:
skia: Disable analytic AA (Closed)
Descriptionskia: Disable analytic AA
Disable analytic AA as it is consistently causing crashes on the
performance waterfall, e.g.:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/builds/13936/steps/smoothness.tough_path_rendering_cases/logs/stdio
This is effectively a revert of
https://codereview.chromium.org/2457393004 without the changes to the
test expectations since they do not revert cleanly any longer.
BUG=662722
TBR=fmalita@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/568cf3e90941a42d1e85108417c385537c7d72ca
Patch Set 1 #
Messages
Total messages: 15 (6 generated)
Description was changed from ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 ========== to ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org ==========
skyostil@chromium.org changed reviewers: + fmalita@chromium.org
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hey Florin, I saw this was causing some crashes on the perf waterfall (in SkScan_AAAPath.cpp), so rather than disabling the tests I thought it would be better to turn the feature off for now. Unfortunately the test expectations have already been updated so I'm not sure if I can land this revert.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/11/07 12:27:20, Sami wrote: > Hey Florin, I saw this was causing some crashes on the perf waterfall (in > SkScan_AAAPath.cpp), so rather than disabling the tests I thought it would be > better to turn the feature off for now. Unfortunately the test expectations have > already been updated so I'm not sure if I can land this revert. Hey Sami, yes this will break some 2000 layout tests. Can you point to the crashes? I take it they're in release mode, nut just asserts? If we need to revert, I'll start unfurling everything manually.
On 2016/11/07 13:30:02, f(malita) wrote: > On 2016/11/07 12:27:20, Sami wrote: > > Hey Florin, I saw this was causing some crashes on the perf waterfall (in > > SkScan_AAAPath.cpp), so rather than disabling the tests I thought it would be > > better to turn the feature off for now. Unfortunately the test expectations > have > > already been updated so I'm not sure if I can land this revert. > > Hey Sami, yes this will break some 2000 layout tests. > > Can you point to the crashes? I take it they're in release mode, nut just > asserts? > > If we need to revert, I'll start unfurling everything manually. OK, I think I see it: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... Looks like a nullptr deref: Crash reason: SIGSEGV Crash address: 0x20 Process uptime: not available Thread 6 (crashed) 0 chrome!<name omitted> [SkScan_AAAPath.cpp : 918 + 0x0] I'll see if I can still revert this.
Thank you all! I'll check this crash soon. On Nov 7, 2016 8:43 AM, <fmalita@google.com> wrote: > On 2016/11/07 13:30:02, f(malita) wrote: > > On 2016/11/07 12:27:20, Sami wrote: > > > Hey Florin, I saw this was causing some crashes on the perf waterfall > (in > > > SkScan_AAAPath.cpp), so rather than disabling the tests I thought it > would > be > > > better to turn the feature off for now. Unfortunately the test > expectations > > have > > > already been updated so I'm not sure if I can land this revert. > > > > Hey Sami, yes this will break some 2000 layout tests. > > > > Can you point to the crashes? I take it they're in release mode, nut just > > asserts? > > > > If we need to revert, I'll start unfurling everything manually. > > OK, I think I see it: > https://build.chromium.org/p/chromium.perf/builders/Linux% > 20Perf%20%284%29/builds/13940/steps/smoothness.gpu_ > rasterization.tough_path_rendering_cases/logs/stdio > > Looks like a nullptr deref: > > Crash reason: SIGSEGV > Crash address: 0x20 > Process uptime: not available > > Thread 6 (crashed) > 0 chrome!<name omitted> [SkScan_AAAPath.cpp : 918 + 0x0] > > I'll see if I can still revert this. > > https://codereview.chromium.org/2476273002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Description was changed from ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org ========== to ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org Committed: https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca Cr-Commit-Position: refs/heads/master@{#430268} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca Cr-Commit-Position: refs/heads/master@{#430268}
Message was sent while issue was closed.
Description was changed from ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org Committed: https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca Cr-Commit-Position: refs/heads/master@{#430268} ========== to ========== skia: Disable analytic AA Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/bu... This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/568cf3e90941a42d1e85108417c3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 568cf3e90941a42d1e85108417c385537c7d72ca (presubmit successful).
Message was sent while issue was closed.
On 2016/11/07 14:26:21, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca > Cr-Commit-Position: refs/heads/master@{#430268} Landed a manual revert of the original CL and all dependent rebaselines: fae14ce1a1116a1d312a2a8639bf260d6fe50083 81f338e0f394826ceabceddedbc570e806cb2c17 96c45c3792d8224ac7e654fd039ad8b56f208b34 5af2b4f8e80d7b714d4b50fe2809c8d44963494f 79c1b5fe773a066684173840439318fa0ca113f4 20fc8c6a410657957e6dd7b258a41c7b9d395a2c 88fa326c7436973c35c1380617a238c668e5727e 4a0d5c49ed80db016581bd0eb263c660352c3d98 edef734a016f919ec329e71aadb0d244214852e0 2a787d8f53aed8286e728c0fb521a68176cdfc4a |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
