|
|
Description[Sensors] Add an UMA histogram for Generic Sensor function calls
All Sensor functions have a histogram value that is recorded when the function is called.
Specification: https://w3c.github.io/sensors/
BUG=606766
Committed: https://crrev.com/c1b9c618e9490fb05ad15612291ef6df37df6fe1
Cr-Commit-Position: refs/heads/master@{#431259}
Patch Set 1 #Patch Set 2 : rebased #
Total comments: 2
Patch Set 3 : Comments from Reilly #Patch Set 4 : rebased #Patch Set 5 : rebased #
Messages
Total messages: 36 (26 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 ========== to ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 ==========
mikhail.pozdnyakov@intel.com changed reviewers: + alexander.shalamov@intel.com, haraken@chromium.org, reillyg@chromium.org
The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/sensor/Sensor.idl (right): https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/sensor/Sensor.idl:24: [CallWith=ScriptState, RaisesException, MeasureAs = GenericSensorStop] void stop(); Is there a reason for putting spaces around the equals sign for MeasureAs and not CallWith? Other uses of MeasureAs have no spaces.
https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/sensor/Sensor.idl (right): https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/sensor/Sensor.idl:24: [CallWith=ScriptState, RaisesException, MeasureAs = GenericSensorStop] void stop(); On 2016/11/08 16:33:27, Reilly Grant wrote: > Is there a reason for putting spaces around the equals sign for MeasureAs and > not CallWith? Other uses of MeasureAs have no spaces. No specific reason, just did not switch from C++ writing :) Fixed now.
lgtm
The CQ bit was checked by mikhail.pozdnyakov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2476253002/#ps60001 (title: "Comments from Reilly")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mikhail.pozdnyakov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, reillyg@chromium.org Link to the patchset: https://codereview.chromium.org/2476253002/#ps100001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 ========== to ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 ========== to ========== [Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 Committed: https://crrev.com/c1b9c618e9490fb05ad15612291ef6df37df6fe1 Cr-Commit-Position: refs/heads/master@{#431259} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/c1b9c618e9490fb05ad15612291ef6df37df6fe1 Cr-Commit-Position: refs/heads/master@{#431259} |