Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 2476253002: [Sensors] Add an UMA histogram for Generic Sensor function calls (Closed)

Created:
4 years, 1 month ago by Mikhail
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Add an UMA histogram for Generic Sensor function calls All Sensor functions have a histogram value that is recorded when the function is called. Specification: https://w3c.github.io/sensors/ BUG=606766 Committed: https://crrev.com/c1b9c618e9490fb05ad15612291ef6df37df6fe1 Cr-Commit-Position: refs/heads/master@{#431259}

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : Comments from Reilly #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (26 generated)
Mikhail
PTAL
4 years, 1 month ago (2016-11-08 10:26:04 UTC) #10
haraken
LGTM
4 years, 1 month ago (2016-11-08 10:45:52 UTC) #11
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Source/modules/sensor/Sensor.idl File third_party/WebKit/Source/modules/sensor/Sensor.idl (right): https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Source/modules/sensor/Sensor.idl#newcode24 third_party/WebKit/Source/modules/sensor/Sensor.idl:24: [CallWith=ScriptState, RaisesException, MeasureAs = GenericSensorStop] void stop(); Is there ...
4 years, 1 month ago (2016-11-08 16:33:27 UTC) #14
Mikhail
https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Source/modules/sensor/Sensor.idl File third_party/WebKit/Source/modules/sensor/Sensor.idl (right): https://codereview.chromium.org/2476253002/diff/40001/third_party/WebKit/Source/modules/sensor/Sensor.idl#newcode24 third_party/WebKit/Source/modules/sensor/Sensor.idl:24: [CallWith=ScriptState, RaisesException, MeasureAs = GenericSensorStop] void stop(); On 2016/11/08 ...
4 years, 1 month ago (2016-11-09 08:49:13 UTC) #15
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-09 15:55:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476253002/60001
4 years, 1 month ago (2016-11-10 07:30:35 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/303312) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-10 07:32:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476253002/100001
4 years, 1 month ago (2016-11-10 15:04:41 UTC) #32
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 1 month ago (2016-11-10 15:09:32 UTC) #34
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 15:14:20 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c1b9c618e9490fb05ad15612291ef6df37df6fe1
Cr-Commit-Position: refs/heads/master@{#431259}

Powered by Google App Engine
This is Rietveld 408576698