Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2476243002: Remove requisition parameter for Chromad. (Closed)

Created:
4 years, 1 month ago by Thiemo Nagel
Modified:
4 years, 1 month ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove requisition parameter for Chromad. The server returns an error when the chrome_ad requisition parameter is set, thus removing it to unblock testing and further work. BUG=639066 Committed: https://crrev.com/f77f4925ac2b43590677b5cfdce55ce161de48a1 Cr-Commit-Position: refs/heads/master@{#430255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Thiemo Nagel
Could you please take a look? Thank you, Thiemo
4 years, 1 month ago (2016-11-07 11:17:37 UTC) #5
Roman Sorokin (ftl)
lgtm
4 years, 1 month ago (2016-11-07 11:19:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476243002/20001
4 years, 1 month ago (2016-11-07 11:21:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-07 12:12:47 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f77f4925ac2b43590677b5cfdce55ce161de48a1 Cr-Commit-Position: refs/heads/master@{#430255}
4 years, 1 month ago (2016-11-07 12:14:48 UTC) #12
Roman Sorokin (ftl)
4 years ago (2016-11-24 13:23:17 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2528923002/ by rsorokin@chromium.org.

The reason for reverting is: Reverting this cause server side was fixed and now
works good..

Powered by Google App Engine
This is Rietveld 408576698