Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2476213002: [turbofan] Don't flush LoadElimination on unsupported field stores. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't flush LoadElimination on unsupported field stores. When we hit an unspported field store, only flush the state of potentially aliasing objects, but don't flush the full state table. R=jarin@chromium.org BUG=v8:5608 Committed: https://crrev.com/78f0d04ceffc562446db852fab15f5d148681ae7 Cr-Commit-Position: refs/heads/master@{#40799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/compiler/load-elimination.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 3 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-07 08:54:50 UTC) #1
Benedikt Meurer
Hey Jaro, Next LoadElimination fix. Please take a look. Thanks, Benedikt
4 years, 1 month ago (2016-11-07 08:55:17 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-07 09:55:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476213002/1
4 years, 1 month ago (2016-11-07 11:12:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 11:14:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:24:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78f0d04ceffc562446db852fab15f5d148681ae7
Cr-Commit-Position: refs/heads/master@{#40799}

Powered by Google App Engine
This is Rietveld 408576698