Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2476193002: Convert editing/spelling/spelling-backward.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-backward.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/3b156bf2e21434d57480a7d0400e899cefa48916 Cr-Commit-Position: refs/heads/master@{#430228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spelling-backward.html View 1 chunk +24 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-backward-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-11-07 05:17:44 UTC) #7
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-07 07:08:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476193002/1
4 years, 1 month ago (2016-11-07 07:08:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 07:14:46 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 07:17:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b156bf2e21434d57480a7d0400e899cefa48916
Cr-Commit-Position: refs/heads/master@{#430228}

Powered by Google App Engine
This is Rietveld 408576698