third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h - Issue 2476173002: bluetooth: Invalidate characteristics when disconnecting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

Issue 2476173002: bluetooth: Invalidate characteristics when disconnecting (Closed)

Patch Set: Fix test expectations Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

index eb3fd7196588f1a1253ea9c2b3dd389079426b76..9d085bce3825fefa469d854dd2ed0abacbcf1dce 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

@@ -57,6 +57,7 @@ class BluetoothDevice final : public EventTargetWithInlineData,

ExecutionContext*,

std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit>,

BluetoothRemoteGATTService*);

+ bool isValidCharacteristic(const String& characteristicInstanceId);

// We should disconnect from the device in all of the following cases:

// 1. When the object gets GarbageCollected e.g. it went out of scope.