Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html

Issue 2476173002: bluetooth: Invalidate characteristics when disconnecting (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/gen-characteristic-device-disconnects-invalidates-objects.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html b/third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
index 4001ad48d9766c5cb650deb0bc8b327ed44e0b5f..4dfa58c002ab3f183f67fcf58368cd3232fc988f 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
@@ -11,27 +11,30 @@ promise_test(t => {
optionalServices: [request_disconnection_service_uuid]
}))
.then(device => {
- return device.gatt.connect()
- .then(gattServer => get_request_disconnection(gattServer))
- .then(requestDisconnection => {
- // 1. Attach a listener that tries to reconnect.
- let reconnection = new Promise(resolve => {
- let wrapper = function(event) {
- device.removeEventListener('gattserverdisconnected', wrapper);
- device.gatt.connect().then(resolve);
- };
- device.addEventListener('gattserverdisconnected', wrapper);
+ return device.gatt.connect().then(gattServer => {
+ return get_request_disconnection(gattServer)
+ .then(requestDisconnection1 => {
+ // 1. Attach a listener that tries to reconnect.
+ let reconnection = new Promise(resolve => {
scheib 2016/11/08 01:44:26 name suggestions? s/reconnection/waitUntilReconne
ortuno 2016/11/08 04:51:47 Done.
+ let wrapper = function(event) {
scheib 2016/11/08 01:44:26 s/wrapper/reconnectThenResolve/ ?
ortuno 2016/11/08 04:51:47 Done.
+ device.removeEventListener('gattserverdisconnected', wrapper);
+ device.gatt.connect().then(resolve);
+ };
+ device.addEventListener('gattserverdisconnected', wrapper);
+ });
+ // 2. Disconnect.
+ requestDisconnection1();
+ return reconnection
+ .then(() => get_request_disconnection(gattServer))
+ .then(requestDisconnection2 => {
+ // Resolves after disconnected event.
+ let disconnected = eventPromise(device, 'gattserverdisconnected');
+ // 3. Disconnect after reconnecting.
+ requestDisconnection2();
+ return disconnected;
+ });
});
- // 2. Disconnect.
- requestDisconnection();
- return reconnection.then(() => {
- // Resolves after disconnected event.
- let disconnected = eventPromise(device, 'gattserverdisconnected');
- // 3. Disconnect after reconnecting.
- requestDisconnection();
- return disconnected;
- });
- });
+ });
});
}, 'A device that reconnects during the gattserverdisconnected event ' +
'should still receive gattserverdisconnected events after re-connection.');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/gen-characteristic-device-disconnects-invalidates-objects.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698