Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: content/browser/loader/test_resource_handler.h

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/sync_resource_handler.cc ('k') | content/browser/loader/test_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/test_resource_handler.h
diff --git a/content/browser/loader/test_resource_handler.h b/content/browser/loader/test_resource_handler.h
index 134f9a6e42c5f273647c215619382444be99a920..342aeed810891d6c21ed8f8f7d42382673f52669 100644
--- a/content/browser/loader/test_resource_handler.h
+++ b/content/browser/loader/test_resource_handler.h
@@ -40,15 +40,16 @@ class TestResourceHandler : public ResourceHandler {
// ResourceHandler implementation:
void SetController(ResourceController* controller) override;
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,
ResourceResponse* response,
- bool* defer) override;
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
- bool OnWillStart(const GURL& url, bool* defer) override;
+ bool* defer_or_cancel) override;
+ void OnResponseStarted(ResourceResponse* response,
+ bool* defer_or_cancel) override;
+ void OnWillStart(const GURL& url, bool* defer_or_cancel) override;
bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) override;
- bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
void OnResponseCompleted(const net::URLRequestStatus& status,
bool* defer) override;
void OnDataDownloaded(int bytes_downloaded) override;
@@ -108,6 +109,8 @@ class TestResourceHandler : public ResourceHandler {
scoped_refptr<net::IOBuffer> buffer_;
size_t buffer_size_;
+ ResourceController* controller_ = nullptr;
+
bool on_will_start_result_ = true;
bool on_response_started_result_ = true;
bool on_will_read_result_ = true;
« no previous file with comments | « content/browser/loader/sync_resource_handler.cc ('k') | content/browser/loader/test_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698