Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: content/browser/loader/stream_resource_handler.cc

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/stream_resource_handler.h ('k') | content/browser/loader/sync_resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/stream_resource_handler.cc
diff --git a/content/browser/loader/stream_resource_handler.cc b/content/browser/loader/stream_resource_handler.cc
index 3560f98d17b9c84c252ac0f3f7b33c0de79abefb..932560bfd76549113cab3b2f0c40692d00cfb39b 100644
--- a/content/browser/loader/stream_resource_handler.cc
+++ b/content/browser/loader/stream_resource_handler.cc
@@ -24,21 +24,16 @@ void StreamResourceHandler::SetController(ResourceController* controller) {
ResourceHandler::SetController(controller);
}
-bool StreamResourceHandler::OnRequestRedirected(
+void StreamResourceHandler::OnRequestRedirected(
const net::RedirectInfo& redirect_info,
ResourceResponse* resp,
- bool* defer) {
- return true;
-}
+ bool* defer_or_cancel) {}
-bool StreamResourceHandler::OnResponseStarted(ResourceResponse* resp,
- bool* defer) {
- return true;
-}
+void StreamResourceHandler::OnResponseStarted(ResourceResponse* resp,
+ bool* defer_or_cancel) {}
-bool StreamResourceHandler::OnWillStart(const GURL& url, bool* defer) {
- return true;
-}
+void StreamResourceHandler::OnWillStart(const GURL& url,
+ bool* defer_or_cancel) {}
bool StreamResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
@@ -47,9 +42,9 @@ bool StreamResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
return true;
}
-bool StreamResourceHandler::OnReadCompleted(int bytes_read, bool* defer) {
- writer_.OnReadCompleted(bytes_read, defer);
- return true;
+void StreamResourceHandler::OnReadCompleted(int bytes_read,
+ bool* defer_or_cancel) {
+ writer_.OnReadCompleted(bytes_read, defer_or_cancel);
}
void StreamResourceHandler::OnResponseCompleted(
« no previous file with comments | « content/browser/loader/stream_resource_handler.h ('k') | content/browser/loader/sync_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698