Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: content/browser/download/save_file_resource_handler.h

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_file_resource_handler.h
diff --git a/content/browser/download/save_file_resource_handler.h b/content/browser/download/save_file_resource_handler.h
index 950e49ad14b3c945f92e51ff519b283ce996d839..1ef11eef5530f81ce61c96530d46d579c643af6a 100644
--- a/content/browser/download/save_file_resource_handler.h
+++ b/content/browser/download/save_file_resource_handler.h
@@ -50,15 +50,16 @@ class SaveFileResourceHandler : public ResourceHandler {
// Saves the redirected URL to final_url_, we need to use the original
// URL to match original request.
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,
ResourceResponse* response,
- bool* defer) override;
+ bool* defer_or_cancel) override;
// Sends the download creation information to the download thread.
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
+ void OnResponseStarted(ResourceResponse* response,
+ bool* defer_or_cancel) override;
// Pass-through implementation.
- bool OnWillStart(const GURL& url, bool* defer) override;
+ void OnWillStart(const GURL& url, bool* defer_or_cancel) override;
// Creates a new buffer, which will be handed to the download thread for file
// writing and deletion.
@@ -67,7 +68,7 @@ class SaveFileResourceHandler : public ResourceHandler {
int min_size) override;
// Passes the buffer to the download file writer.
- bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
void OnResponseCompleted(const net::URLRequestStatus& status,
bool* defer) override;
« no previous file with comments | « content/browser/download/download_resource_handler.cc ('k') | content/browser/download/save_file_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698