Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7048)

Unified Diff: content/browser/download/download_resource_handler.h

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/download_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_resource_handler.h
diff --git a/content/browser/download/download_resource_handler.h b/content/browser/download/download_resource_handler.h
index b2820a39a9f1007cc54d3ffb7e3ad59b86d39387..c1a97602c8fb7a1c4d66ddf61ef6fcd01f1b7662 100644
--- a/content/browser/download/download_resource_handler.h
+++ b/content/browser/download/download_resource_handler.h
@@ -49,15 +49,16 @@ class CONTENT_EXPORT DownloadResourceHandler
// ResourceDispatcherHostImpl.
static std::unique_ptr<ResourceHandler> Create(net::URLRequest* request);
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,
ResourceResponse* response,
- bool* defer) override;
+ bool* defer_or_cancel) override;
// Send the download creation information to the download thread.
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
+ void OnResponseStarted(ResourceResponse* response,
+ bool* defer_or_cancel) override;
// Pass-through implementation.
- bool OnWillStart(const GURL& url, bool* defer) override;
+ void OnWillStart(const GURL& url, bool* defer_or_cancel) override;
// Create a new buffer, which will be handed to the download thread for file
// writing and deletion.
@@ -65,7 +66,7 @@ class CONTENT_EXPORT DownloadResourceHandler
int* buf_size,
int min_size) override;
- bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
void OnResponseCompleted(const net::URLRequestStatus& status,
bool* defer) override;
« no previous file with comments | « no previous file | content/browser/download/download_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698