Refactor ResourceHandler API.

content/browser/loader/mime_sniffing_resource_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_LOADER_MIME_SNIFFING_RESOURCE_HANDLER_H_
 #define CONTENT_BROWSER_LOADER_MIME_SNIFFING_RESOURCE_HANDLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 62 matching lines @@
     STATE_REPLAYING_RESPONSE_RECEIVED,
 
     // In this state, the MimeSniffingResourceHandler is just a blind
     // pass-through
     // ResourceHandler.
     STATE_STREAMING,
   };
 
   // ResourceHandler implementation:
   void SetController(ResourceController* controller) override;
-  bool OnWillStart(const GURL&, bool* defer) override;
-  bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
+  void OnWillStart(const GURL&, bool* defer_or_cancel) override;
+  void OnResponseStarted(ResourceResponse* response,
+                         bool* defer_or_cancel) override;
   bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
                   int* buf_size,
                   int min_size) override;
-  bool OnReadCompleted(int bytes_read, bool* defer) override;
+  void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
   void OnResponseCompleted(const net::URLRequestStatus& status,
                            bool* defer) override;
 
   // ResourceController implementation:
   void Resume() override;
   void Cancel() override;
   void CancelAndIgnore() override;
   void CancelWithError(int error_code) override;
 
   // --------------------------------------------------------------------------
   // The following methods replay the buffered data to the downstream
-  // ResourceHandlers. They return false if the request should be cancelled,
-  // true otherwise. Each of them will set |defer| to true if the request will
-  // proceed to the next stage asynchronously.
+  // ResourceHandlers. Each of them will set |defer_or_cancel| to true if the
+  // request should not synchronously continue (It was canceled, or will be
+  // continued/canceled asynchronously.
 
   // Used to advance through the states of the state machine.
   void AdvanceState();
-  bool ProcessState(bool* defer);
+  void ProcessState(bool* defer_or_cancel);
 
   // Intercepts the request as a stream/download if needed.
-  bool MaybeIntercept(bool* defer);
+  void MaybeIntercept(bool* defer_or_cancel);
 
   // Replays OnResponseStarted on the downstream handlers.
-  bool ReplayResponseReceived(bool* defer);
+  void ReplayResponseReceived(bool* defer_or_cancel);
 
   // Replays OnReadCompleted on the downstreams handlers.
-  bool ReplayReadCompleted(bool* defer);
+  void ReplayReadCompleted(bool* defer_or_cancel);
 
   // --------------------------------------------------------------------------
 
   // Whether the response body should be sniffed in order to determine the MIME
   // type of the response.
   bool ShouldSniffContent();
 
   // Checks whether this request should be intercepted as a stream or a
   // download. If this is the case, sets up the new ResourceHandler that will be
-  // used for interception. Returns false if teh request should be cancelled,
-  // true otherwise. |defer| is set to true if the interception check needs to
-  // finish asynchronously.
-  bool MaybeStartInterception(bool* defer);
+  // used for interception. |defer_or_cancel| is set to true if the request will
+  // be resumed asynchronously, or was canceled.
+  void MaybeStartInterception(bool* defer_or_cancel);
 
-  // Determines whether a plugin will handle the current request. Returns false
-  // if there is an error and the request should be cancelled and true
-  // otherwise. |defer| is set to true if plugin data is stale and needs to be
-  // refreshed before the request can be handled (in this case the function
-  // still returns true). If the request is directed to a plugin,
-  // |handled_by_plugin| is set to true.
-  bool CheckForPluginHandler(bool* defer, bool* handled_by_plugin);
+  // Determines whether a plugin will handle the current request.
+  // |defer_or_cancel| is set to true if plugin data is stale and needs to be
+  // refreshed before the request can be handled, or if the request was
+  // canceled. If the request is directed to a plugin, |handled_by_plugin| is
+  // set to true.
+  void CheckForPluginHandler(bool* defer_or_cancel, bool* handled_by_plugin);
 
   // Whether this request is allowed to be intercepted as a download or a
   // stream.
   bool CanBeIntercepted();
 
   // Whether the response we received is not provisional.
   bool CheckResponseIsNotProvisional();
 
   bool MustDownload();
 
@@ skipping 23 matching lines @@
   RequestContextType request_context_type_;
 
   base::WeakPtrFactory<MimeSniffingResourceHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MimeSniffingResourceHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_LOADER_MIME_SNIFFING_RESOURCE_HANDLER_H_