Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2476153002:
Use mojo support for Blink devicechange event. (Closed)
|
Created:
4 years, 1 month ago by Guido Urdaneta Modified:
4 years, 1 month ago Reviewers:
hbos_chromium CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse mojo support for Blink devicechange event.
BUG=648183
Committed: https://crrev.com/6a0339c962198b75c333eb14bafa6374890d738a
Cr-Commit-Position: refs/heads/master@{#430318}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase, Add TODO, fix leak in test #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 27 (20 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
guidou@chromium.org changed reviewers: + hbos@chromium.org
Hi, PTAL
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
lgtm https://codereview.chromium.org/2476153002/diff/60001/content/renderer/media/... File content/renderer/media/user_media_client_impl.cc (right): https://codereview.chromium.org/2476153002/diff/60001/content/renderer/media/... content/renderer/media/user_media_client_impl.cc:637: NOTREACHED(); nit: Add a TODO comment that the interface is about to change and that this function will soon be removed.
Patchset #2 (id:80001) has been deleted
https://codereview.chromium.org/2476153002/diff/60001/content/renderer/media/... File content/renderer/media/user_media_client_impl.cc (right): https://codereview.chromium.org/2476153002/diff/60001/content/renderer/media/... content/renderer/media/user_media_client_impl.cc:637: NOTREACHED(); On 2016/11/07 12:48:33, hbos_chromium wrote: > nit: Add a TODO comment that the interface is about to change and that this > function will soon be removed. Done.
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org Link to the patchset: https://codereview.chromium.org/2476153002/#ps120001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Use mojo support for Blink devicechange event. BUG=648183 ========== to ========== Use mojo support for Blink devicechange event. BUG=648183 Committed: https://crrev.com/6a0339c962198b75c333eb14bafa6374890d738a Cr-Commit-Position: refs/heads/master@{#430318} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6a0339c962198b75c333eb14bafa6374890d738a Cr-Commit-Position: refs/heads/master@{#430318}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:120001) has been created in https://codereview.chromium.org/2483413002/ by guidou@chromium.org. The reason for reverting is: Reverting due to this CL due to it blocking the revert of another CL that is interfering with perf tests. Will reland after that. See crbug.com/662414. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
