third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp - Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)

Patch Set: address comments from #6 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

index bac530d4d83d14566d082b7981998d5b0f5cfa26..7234bb822490b2f676d4bcf3df3330e4e615f6ba 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

@@ -78,7 +78,7 @@ GraphicsContext::GraphicsContext(PaintController& paintController,

m_paintState = m_paintStateStack.last().get();

if (contextDisabled()) {

- DEFINE_STATIC_LOCAL(SkCanvas*, nullCanvas, (SkCreateNullCanvas()));

+ DEFINE_STATIC_LOCAL(SkCanvas*, nullCanvas, (SkMakeNullCanvas().release()));

m_canvas = nullCanvas;

}