Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: ui/surface/transport_dib_posix.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)
Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/surface/transport_dib_posix.cc
diff --git a/ui/surface/transport_dib_posix.cc b/ui/surface/transport_dib_posix.cc
index da370c96698e87a4aee7381272494c61c1bf07d8..e58f5054fd5dbdc6c73f7194f6bc66b7fe570838 100644
--- a/ui/surface/transport_dib_posix.cc
+++ b/ui/surface/transport_dib_posix.cc
@@ -63,7 +63,8 @@ SkCanvas* TransportDIB::GetPlatformCanvas(int w, int h, bool opaque) {
return NULL;
return skia::CreatePlatformCanvas(w, h, opaque,
reinterpret_cast<uint8_t*>(memory()),
- skia::RETURN_NULL_ON_FAILURE);
+ skia::RETURN_NULL_ON_FAILURE)
+ .release();
danakj 2016/11/14 19:35:15 Please make GetPlatformCanvas return a unique_ptr
reed1 2016/11/14 20:50:08 Done.
}
bool TransportDIB::Map() {

Powered by Google App Engine
This is Rietveld 408576698