Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ui/compositor/paint_recorder.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)
Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/paint_recorder.cc
diff --git a/ui/compositor/paint_recorder.cc b/ui/compositor/paint_recorder.cc
index 2c01e5c43d9c9f41835f99f91c3e8ea54b876a58..2b10187738af958db8b052ecc57270c4031388f0 100644
--- a/ui/compositor/paint_recorder.cc
+++ b/ui/compositor/paint_recorder.cc
@@ -21,8 +21,8 @@ PaintRecorder::PaintRecorder(const PaintContext& context,
// The SkCanvas reference returned by beginRecording is shared with
// the recorder_ so no need to store a RefPtr to it on this class, we just
danakj 2016/11/14 19:36:51 This comment is out of date now. Can you have it i
reed1 2016/11/14 20:50:08 Done.
// store the gfx::Canvas.
- canvas_(sk_ref_sp(context.recorder_->beginRecording(
- gfx::RectToSkRect(gfx::Rect(recording_size)))),
+ canvas_(context.recorder_->beginRecording(
+ gfx::RectToSkRect(gfx::Rect(recording_size))),
context.device_scale_factor_),
cache_(cache),
bounds_in_layer_(context.ToLayerSpaceBounds(recording_size)) {

Powered by Google App Engine
This is Rietveld 408576698