ppapi/proxy/ppb_image_data_proxy.cc - Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_image_data_proxy.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)

Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/ppb_image_data_proxy.cc

diff --git a/ppapi/proxy/ppb_image_data_proxy.cc b/ppapi/proxy/ppb_image_data_proxy.cc

index bde81b43fb62c550ca95f29970a585b655871373..7f0b544c395b34855f6ff062936a80e6526450ad 100644

--- a/ppapi/proxy/ppb_image_data_proxy.cc

+++ b/ppapi/proxy/ppb_image_data_proxy.cc

@@ -391,10 +391,8 @@ void* PlatformImageData::Map() {

return NULL;

const bool is_opaque = false;

- mapped_canvas_ =

- sk_sp<SkCanvas>(transport_dib_->GetPlatformCanvas(desc_.size.width,

- desc_.size.height,

- is_opaque));

+ mapped_canvas_.reset(transport_dib_->GetPlatformCanvas(

+ desc_.size.width, desc_.size.height, is_opaque));

if (!mapped_canvas_.get())

return NULL;

}