content/renderer/pepper/pepper_plugin_instance_impl.h - Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)

Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.h

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h

index cac1a756e4ee03bf98efa6cf5c860e1713df6490..613ed4b43b2a2b2baa2ad29e8e793db44c92c06a 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.h

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h

@@ -837,7 +837,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

// to generate the entire PDF given the variables below:

// The most recently used WebCanvas, guaranteed to be valid.

- sk_sp<blink::WebCanvas> canvas_;

+ blink::WebCanvas* canvas_;

f(malita) 2016/11/14 17:29:15 This changes the ownership model. Are we sure the

reed1 2016/11/14 20:50:08 Done.

// An array of page ranges.

std::vector<PP_PrintPageNumberRange_Dev> ranges_;