cc/playback/discardable_image_map.h - Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/playback/discardable_image_map.h

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)

Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/playback/discardable_image_map.h

diff --git a/cc/playback/discardable_image_map.h b/cc/playback/discardable_image_map.h

index adae86248074cf55fec472076a52369a56fe49b0..00506809a5fcba8869307187813fbd9bd8a72a4a 100644

--- a/cc/playback/discardable_image_map.h

+++ b/cc/playback/discardable_image_map.h

@@ -36,7 +36,7 @@ class CC_EXPORT DiscardableImageMap {

private:

DiscardableImageMap* image_map_;

- sk_sp<SkCanvas> metadata_canvas_;

+ std::unique_ptr<SkCanvas> metadata_canvas_;

};

DiscardableImageMap();

@@ -51,7 +51,7 @@ class CC_EXPORT DiscardableImageMap {

friend class ScopedMetadataGenerator;

friend class DiscardableImageMapTest;

- sk_sp<SkCanvas> BeginGeneratingMetadata(const gfx::Size& bounds);

+ std::unique_ptr<SkCanvas> BeginGeneratingMetadata(const gfx::Size& bounds);

void EndGeneratingMetadata();

std::vector<std::pair<DrawImage, gfx::Rect>> all_images_;