blimp/test/support/compositor/picture_cache_test_support.cc - Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/test/support/compositor/picture_cache_test_support.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)

Patch Set: no need for unique check on unique_ptr Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/test/support/compositor/picture_cache_test_support.cc

diff --git a/blimp/test/support/compositor/picture_cache_test_support.cc b/blimp/test/support/compositor/picture_cache_test_support.cc

index 1f2b35c8b4a6614c094dbeaf6675a68a8b19974f..58cd52fd293320c7843736d81c8fa7a2b245cd5d 100644

--- a/blimp/test/support/compositor/picture_cache_test_support.cc

+++ b/blimp/test/support/compositor/picture_cache_test_support.cc

@@ -22,8 +22,7 @@ namespace blimp {

sk_sp<const SkPicture> CreateSkPicture(SkColor color) {

SkPictureRecorder recorder;

- sk_sp<SkCanvas> canvas =

- sk_ref_sp(recorder.beginRecording(SkRect::MakeWH(1, 1)));

+ SkCanvas* canvas = recorder.beginRecording(SkRect::MakeWH(1, 1));

canvas->drawColor(color);

return recorder.finishRecordingAsPicture();

}