Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8601)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2476073003: Update PpdProvider threading model. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/printing/ppd_provider.h » ('j') | chromeos/printing/ppd_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
index fb7ebb240c5b863c6ebccd761107c89ad7883f50..3f783c505a614c9fd4a7b141b89634d08ee33a6a 100644
--- a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
@@ -83,6 +83,9 @@ CupsPrintersHandler::CupsPrintersHandler(content::WebUI* webui)
base::PathService::Get(chrome::DIR_CHROMEOS_PPD_CACHE, &ppd_cache_path));
ppd_provider_ = chromeos::printing::PpdProvider::Create(
google_apis::GetAPIKey(), g_browser_process->system_request_context(),
+ content::BrowserThread::GetTaskRunnerForThread(
+ content::BrowserThread::FILE)
+ .get(),
skau 2016/11/09 00:01:09 Why are you using the raw pointer instead of the s
Carlson 2016/11/10 19:22:50 Changed to scoped_refptr (see other comment)
chromeos::printing::PpdCache::Create(ppd_cache_path));
}
« no previous file with comments | « no previous file | chromeos/printing/ppd_provider.h » ('j') | chromeos/printing/ppd_provider.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698