Run optional GPU trybots against changes to media/audio/ .

Run optional GPU trybots against changes to media/audio/ .

The main effect this has is to run the WebGL 2.0 conformance suite
against CLs in this directory, and subdirectories. This test suite
contains videos that test code paths in media/audio/, so running it on
CQ jobs should prevent breakage of these tests.

BUG=659641
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fb52b0f9af558002450baf25cacbc98feb9201e2
Cr-Commit-Position: refs/heads/master@{#430079}

[Ken Russell (switch to Gerrit), 2016-11-04 22:53:59]

Description was changed from

==========
Run optional GPU trybots against changes to media/audio/ .

The main effect this has is to run the WebGL 2.0 conformance suite
against CLs in this directory, and subdirectories. This test suite
contains videos that test code paths in media/audio/, so running it on
CQ jobs should prevent breakage of these tests.

BUG=659641
==========

to

==========
Run optional GPU trybots against changes to media/audio/ .

The main effect this has is to run the WebGL 2.0 conformance suite
against CLs in this directory, and subdirectories. This test suite
contains videos that test code paths in media/audio/, so running it on
CQ jobs should prevent breakage of these tests.

BUG=659641
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-04 22:55:17]

kbr@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-04 22:55:18]

PTAL.

This was informed by the revert of https://codereview.chromium.org/2475453003/ .

Raymond, could you please add the CQ_INCLUDE_TRYBOTS line from this CL to any
subsequent version of your CL, in case this doesn't land (and you don't sync it
into your workspace) before you upload a new version of your patch? Thanks.

[DaleCurtis, 2016-11-04 22:56:40]

lgtm, I'd also support adding this to media/gpu

[Ken Russell (switch to Gerrit), 2016-11-04 22:59:39]

On 2016/11/04 22:56:40, DaleCurtis wrote:
> lgtm, I'd also support adding this to media/gpu

Thanks, added there too. CQ'ing.

[Ken Russell (switch to Gerrit), 2016-11-04 22:59:52]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-04 22:59:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2476053002/#ps20001
(title: "Add these tryservers for changes in media/gpu/ too.")

[commit-bot: I haz the power, 2016-11-04 23:00:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ynovikov, 2016-11-04 23:03:39]

ynovikov@chromium.org changed reviewers:
+ ynovikov@chromium.org

[ynovikov, 2016-11-04 23:03:39]

https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.py
File media/audio/PRESUBMIT.py (right):

https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.p...
media/audio/PRESUBMIT.py:28: bots = [
Does it make sense to add android_optional_gpu_tests_rel here as well?
Or some other audio path is being used on Android?

[ynovikov, 2016-11-04 23:06:16]

On 2016/11/04 23:03:39, ynovikov wrote:
> https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.py
> File media/audio/PRESUBMIT.py (right):
> 
>
https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.p...
> media/audio/PRESUBMIT.py:28: bots = [
> Does it make sense to add android_optional_gpu_tests_rel here as well?
> Or some other audio path is being used on Android?

BTW, it makes sense to run one 1 bot if changes affect only one platform. I.e.
only android_optional_gpu_tests_rel for android subdir, but all the bots for
changes at upper level.

[Ken Russell (switch to Gerrit), 2016-11-04 23:25:55]

On 2016/11/04 23:06:16, ynovikov wrote:
> On 2016/11/04 23:03:39, ynovikov wrote:
> >
https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.py
> > File media/audio/PRESUBMIT.py (right):
> > 
> >
>
https://codereview.chromium.org/2476053002/diff/20001/media/audio/PRESUBMIT.p...
> > media/audio/PRESUBMIT.py:28: bots = [
> > Does it make sense to add android_optional_gpu_tests_rel here as well?
> > Or some other audio path is being used on Android?
> 
> BTW, it makes sense to run one 1 bot if changes affect only one platform. I.e.
> only android_optional_gpu_tests_rel for android subdir, but all the bots for
> changes at upper level.

We can consider adding the android_optional_gpu_tests_rel trybot to this
presubmit check later. The last time I looked it wasn't reliably green, and I
wasn't comfortable asking other teams than ours to run it.

[commit-bot: I haz the power, 2016-11-05 00:21:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 00:22:50]

Description was changed from

==========
Run optional GPU trybots against changes to media/audio/ .

The main effect this has is to run the WebGL 2.0 conformance suite
against CLs in this directory, and subdirectories. This test suite
contains videos that test code paths in media/audio/, so running it on
CQ jobs should prevent breakage of these tests.

BUG=659641
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Run optional GPU trybots against changes to media/audio/ .

The main effect this has is to run the WebGL 2.0 conformance suite
against CLs in this directory, and subdirectories. This test suite
contains videos that test code paths in media/audio/, so running it on
CQ jobs should prevent breakage of these tests.

BUG=659641
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fb52b0f9af558002450baf25cacbc98feb9201e2
Cr-Commit-Position: refs/heads/master@{#430079}
==========

[commit-bot: I haz the power, 2016-11-05 00:22:51]

Patchset 2 (id:??) landed as
https://crrev.com/fb52b0f9af558002450baf25cacbc98feb9201e2
Cr-Commit-Position: refs/heads/master@{#430079}