Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: src/handles-inl.h

Issue 2476001: Current HandleScope moving to Isolate. (Closed)
Patch Set: removed unnesessary initializing constand, using existing Initialize() for handle scope data. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/handles.cc ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 inline T* Handle<T>::operator*() const { 47 inline T* Handle<T>::operator*() const {
48 ASSERT(location_ != NULL); 48 ASSERT(location_ != NULL);
49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue); 49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue);
50 return *location_; 50 return *location_;
51 } 51 }
52 52
53 53
54 #ifdef DEBUG 54 #ifdef DEBUG
55 inline NoHandleAllocation::NoHandleAllocation() { 55 inline NoHandleAllocation::NoHandleAllocation() {
56 v8::ImplementationUtilities::HandleScopeData* current = 56 v8::ImplementationUtilities::HandleScopeData* current =
57 v8::ImplementationUtilities::CurrentHandleScope(); 57 Isolate::Current()->handle_scope_data();
58 extensions_ = current->extensions; 58 extensions_ = current->extensions;
59 // Shrink the current handle scope to make it impossible to do 59 // Shrink the current handle scope to make it impossible to do
60 // handle allocations without an explicit handle scope. 60 // handle allocations without an explicit handle scope.
61 current->limit = current->next; 61 current->limit = current->next;
62 current->extensions = -1; 62 current->extensions = -1;
63 } 63 }
64 64
65 65
66 inline NoHandleAllocation::~NoHandleAllocation() { 66 inline NoHandleAllocation::~NoHandleAllocation() {
67 // Restore state in current handle scope to re-enable handle 67 // Restore state in current handle scope to re-enable handle
68 // allocations. 68 // allocations.
69 v8::ImplementationUtilities::CurrentHandleScope()->extensions = extensions_; 69 Isolate::Current()->handle_scope_data()->extensions = extensions_;
70 } 70 }
71 #endif 71 #endif
72 72
73 73
74 } } // namespace v8::internal 74 } } // namespace v8::internal
75 75
76 #endif // V8_HANDLES_INL_H_ 76 #endif // V8_HANDLES_INL_H_
OLDNEW
« no previous file with comments | « src/handles.cc ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698