Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2475973003: Revert of Delete tryserver_gerrit and its old properties. (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Delete tryserver_gerrit and its old properties. (patchset #1 id:1 of https://codereview.chromium.org/2464673002/ ) Reason for revert: broke roll Original issue's description: > Delete tryserver_gerrit and its old properties. > > R=martiniss@chromium.org,machenbach@chromium.org > BUG=chromium:645616 > > Committed: https://github.com/luci/recipes-py/commit/2ecaa8b5944f016f6bda5cbe93ec6f54e8ead4fb TBR=machenbach@chromium.org,tandrii@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:645616 Committed: https://github.com/luci/recipes-py/commit/6d04a2a25f68b37024e9d45ff32252e4d4903664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -2 lines) Patch
M recipe_engine/unittests/recipe_api_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.py View 1 chunk +6 lines, -0 lines 0 comments Download
A recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_deprecated.json View 1 chunk +45 lines, -0 lines 0 comments Download
M recipe_modules/properties/test_api.py View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
martiniss
Created Revert of Delete tryserver_gerrit and its old properties.
4 years, 1 month ago (2016-11-04 22:11:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475973003/1
4 years, 1 month ago (2016-11-04 22:11:38 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:13:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/6d04a2a25f68b37024e9d45ff32252e4d49...

Powered by Google App Engine
This is Rietveld 408576698