Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2475953002: [Autofill] Change spacing in the local card editor, address editor (Android) (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, gogerald1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Change spacing in the local card editor, address editor (Android) Now a consistent 72dp between blocks. Screenshots: https://drive.google.com/open?id=0B3xzZ-vFr2LROURsSlh3Z2M5bXM https://drive.google.com/open?id=0B3xzZ-vFr2LRQTVXOXF0LXlaTEE BUG=662436 TEST=Manual Committed: https://crrev.com/8ec1e16449eb94f0cbe7a1e420eda6f151e54f27 Cr-Commit-Position: refs/heads/master@{#429970}

Patch Set 1 #

Patch Set 2 : Further adjust top margins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M chrome/android/java/res/layout/autofill_editor_base.xml View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/autofill_local_card_editor.xml View 1 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/autofill_profile_editor.xml View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/autofill_server_card_editor.xml View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/preference_address_float_label_layout.xml View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mathieu
Dan PTAL, thanks!
4 years, 1 month ago (2016-11-04 16:31:22 UTC) #2
gone
lgtm, looks pretty nice.
4 years, 1 month ago (2016-11-04 16:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475953002/1
4 years, 1 month ago (2016-11-04 16:59:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475953002/20001
4 years, 1 month ago (2016-11-04 18:30:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 19:11:46 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 19:18:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ec1e16449eb94f0cbe7a1e420eda6f151e54f27
Cr-Commit-Position: refs/heads/master@{#429970}

Powered by Google App Engine
This is Rietveld 408576698