Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2475933002: Fix typo on quic_protocol.h (Closed)

Created:
4 years, 1 month ago by Alexis La Goutte
Modified:
4 years ago
Reviewers:
Ryan Hamilton, alyssar
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo on quic_protocol.h Hanshake => Handshake occured => occurred BUG= Committed: https://crrev.com/4c219f8ee99213115a8cfd6677d9b0dea34baff9 Cr-Commit-Position: refs/heads/master@{#436210}

Patch Set 1 #

Patch Set 2 : Fix typo on quic_error_codes.h (ex quic_protocol.h) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_error_codes.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Alexis La Goutte
4 years, 1 month ago (2016-11-04 13:47:39 UTC) #2
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-08 22:12:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475933002/1
4 years, 1 month ago (2016-11-08 22:13:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/331463)
4 years, 1 month ago (2016-11-08 23:33:14 UTC) #7
Alexis La Goutte
Hi, What missing for merge ?
4 years, 1 month ago (2016-11-21 10:48:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475933002/1
4 years, 1 month ago (2016-11-21 17:50:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/302036) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-21 17:52:55 UTC) #12
Ryan Hamilton
On 2016/11/21 10:48:02, Alexis La Goutte wrote: > Hi, > > What missing for merge ...
4 years, 1 month ago (2016-11-22 18:54:59 UTC) #13
Alexis La Goutte
resync with upstream (no easy because some file rename...)
4 years ago (2016-12-03 19:48:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475933002/20001
4 years ago (2016-12-05 00:41:52 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 01:41:28 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-05 01:44:08 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c219f8ee99213115a8cfd6677d9b0dea34baff9
Cr-Commit-Position: refs/heads/master@{#436210}

Powered by Google App Engine
This is Rietveld 408576698