|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Alexis La Goutte Modified:
4 years ago CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix typo on quic_protocol.h
Hanshake => Handshake
occured => occurred
BUG=
Committed: https://crrev.com/4c219f8ee99213115a8cfd6677d9b0dea34baff9
Cr-Commit-Position: refs/heads/master@{#436210}
Patch Set 1 #Patch Set 2 : Fix typo on quic_error_codes.h (ex quic_protocol.h) #Messages
Total messages: 21 (9 generated)
alexis.lagoutte@gmail.com changed reviewers: + alyssar@google.com, rch@chromium.org
The CQ bit was checked by rch@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Hi, What missing for merge ?
The CQ bit was checked by rch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
On 2016/11/21 10:48:02, Alexis La Goutte wrote: > Hi, > > What missing for merge ? The patch is failing which likely means you need to re-sync to tip of tree and then re-upload your CL.
resync with upstream (no easy because some file rename...)
The CQ bit was checked by rch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org Link to the patchset: https://codereview.chromium.org/2475933002/#ps20001 (title: "Fix typo on quic_error_codes.h (ex quic_protocol.h)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480898500722190,
"parent_rev": "a4967febaf82572adce803a49e1e3372448462f3", "commit_rev":
"49634cc59c64e4ff032ad8ccd1e0d06f56c9e5f7"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix typo on quic_protocol.h Hanshake => Handshake occured => occurred BUG= ========== to ========== Fix typo on quic_protocol.h Hanshake => Handshake occured => occurred BUG= Committed: https://crrev.com/4c219f8ee99213115a8cfd6677d9b0dea34baff9 Cr-Commit-Position: refs/heads/master@{#436210} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4c219f8ee99213115a8cfd6677d9b0dea34baff9 Cr-Commit-Position: refs/heads/master@{#436210} |
