Implement FPDF_VIEWERREF_GetName() API.

Implement FPDF_VIEWERREF_GetName() API.

This is a generic API function to retrieve any viewer preference of type
name.

BUG=pdfium:414
Committed: https://pdfium.googlesource.com/pdfium/+/04bebfe590d6d27a825b881fd234e31501843edc

[Lei Zhang, 2016-11-04 21:30:07]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:30:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-04 21:38:43]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:38:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-04 21:39:15]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:58:40]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-04 22:25:11]

https://codereview.chromium.org/2475923003/diff/20001/core/fpdfdoc/cpdf_viewe...
File core/fpdfdoc/cpdf_viewerpreferences.h (right):

https://codereview.chromium.org/2475923003/diff/20001/core/fpdfdoc/cpdf_viewe...
core/fpdfdoc/cpdf_viewerpreferences.h:27: bool GenericName(const CFX_ByteString&
bsKey, CFX_ByteString* bsVal) const;
What is the ownership of bsVal? Can you add a comment?

https://codereview.chromium.org/2475923003/diff/20001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2475923003/diff/20001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:961: return dwStringLen;
(CFX_ByteStrings are \0 terminated right?)

[Lei Zhang, 2016-11-04 22:29:56]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 22:30:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-04 22:30:27]

https://codereview.chromium.org/2475923003/diff/20001/core/fpdfdoc/cpdf_viewe...
File core/fpdfdoc/cpdf_viewerpreferences.h (right):

https://codereview.chromium.org/2475923003/diff/20001/core/fpdfdoc/cpdf_viewe...
core/fpdfdoc/cpdf_viewerpreferences.h:27: bool GenericName(const CFX_ByteString&
bsKey, CFX_ByteString* bsVal) const;
On 2016/11/04 22:25:10, dsinclair wrote:
> What is the ownership of bsVal? Can you add a comment?

Done.

https://codereview.chromium.org/2475923003/diff/20001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2475923003/diff/20001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:961: return dwStringLen;
On 2016/11/04 22:25:10, dsinclair wrote:
> (CFX_ByteStrings are \0 terminated right?)

Pretty sure that's the case.

[commit-bot: I haz the power, 2016-11-04 22:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:46:28]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-04 23:06:56]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-04 23:06:57]

lgtm

[commit-bot: I haz the power, 2016-11-04 23:07:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:07:27]

Description was changed from

==========
Implement FPDF_VIEWERREF_GetName() API.

This is a generic API function to retrieve any viewer preference of type
name.

BUG=pdfium:414
==========

to

==========
Implement FPDF_VIEWERREF_GetName() API.

This is a generic API function to retrieve any viewer preference of type
name.

BUG=pdfium:414

Committed:
https://pdfium.googlesource.com/pdfium/+/04bebfe590d6d27a825b881fd234e3150184...
==========

[commit-bot: I haz the power, 2016-11-04 23:07:28]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/04bebfe590d6d27a825b881fd234e3150184...