Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Issue 2475913003: Enabling kUseConsolidatedStartupFlow by default on trunk. (Closed)
Patch Set: Rebase-updated Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_tab_provider_unittest.cc
diff --git a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
index 98139b926c1e7f0731cfef7d0b4be0e938e34578..226f0b79b04b731bf5f7473b98ca6d2f5cfdb7c9 100644
--- a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
+++ b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
@@ -192,25 +192,36 @@ TEST(StartupTabProviderTest, CheckPreferencesTabPolicy) {
SessionStartupPref pref(SessionStartupPref::Type::URLS);
pref.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
- StartupTabs output = StartupTabProviderImpl::CheckPreferencesTabPolicy(pref);
+ StartupTabs output =
+ StartupTabProviderImpl::CheckPreferencesTabPolicy(pref, false);
ASSERT_EQ(1U, output.size());
EXPECT_EQ("www.google.com", output[0].url.host());
}
-TEST(StartupTabProviderTest, CheckPreferencesTabPolicy_Negative) {
+TEST(StartupTabProviderTest, CheckPreferencesTabPolicy_WrongType) {
SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
pref_default.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
StartupTabs output =
- StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_default);
+ StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_default, false);
EXPECT_TRUE(output.empty());
SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
pref_last.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
- output = StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_last);
+ output = StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_last, false);
+
+ EXPECT_TRUE(output.empty());
+}
+
+TEST(StartupTabProviderTest, CheckPreferencesTabPolicy_NotFirstBrowser) {
+ SessionStartupPref pref(SessionStartupPref::Type::URLS);
+ pref.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
+
+ StartupTabs output =
+ StartupTabProviderImpl::CheckPreferencesTabPolicy(pref, true);
EXPECT_TRUE(output.empty());
}
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698